Date: Tue, 19 Jul 2016 13:56:14 +0000 From: Glen Barber <gjb@FreeBSD.org> To: Randall Stewart <rrs@netflix.com> Cc: Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302998 - head/sys/kern Message-ID: <20160719135614.GE65494@FreeBSD.org> In-Reply-To: <03E667D5-A4C9-47B9-A8DD-49ECD0E2B7EB@netflix.com> References: <201607180929.u6I9T9Uw063705@repo.freebsd.org> <64C1543A-3EDE-4852-88EA-5B0B78FCF016@netflix.com> <58868615-8255-4D8B-BD9E-8E19A734CB6C@netflix.com> <5E551FA8-C779-45AE-B038-D8B51B53EEAA@netflix.com> <20160719122545.GC65494@FreeBSD.org> <03E667D5-A4C9-47B9-A8DD-49ECD0E2B7EB@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Jul 19, 2016 at 03:46:54PM +0200, Randall Stewart wrote: > Glen: > > My changes work.. I have them running in NF in at least 1/2 dozen machines. > For how long? What are the uptimes on these machines? This is the blocker for 11.0-BETA2, and I don't want to see more regressions being introduced at this point of the cycle. Glen > I am more than willing to commit them.. they actually are not much different than > whats in stable 10.. though I don’t know if the async-drain was MFC’d there.. it > needs to be in for TCP.. or else you will have yet another mess in that > respect (TCP depends on ASYNC-drain). > > I can commit what I have.. if you like.. or not.. I really don’t care (I hate kern_timeout.c :-o) > > R > > On Jul 19, 2016, at 2:25 PM, Glen Barber <gjb@freebsd.org> wrote: > > > > On Tue, Jul 19, 2016 at 01:43:16PM +0200, Randall Stewart wrote: > >> Gleb > >> > >> Ok > >> > >> I have now updated > >> > >> https://reviews.freebsd.org/D7135 > >> > >> You can take this or not… I really don’t care either way… (you are welcome to > >> own the kern_timeout.c code I hate it) :-) > >> > >> Basically when you went off and re-factored kern_timeout.c I had worked in parallel on fixing > >> the bugs you were seeing.. There were three distinct problems that I fixed… but then > >> you had refactored the stop() routine.. and I thought ok.. thats fine. I had actually thought about > >> doing something similar to what you did and was too chicken to poke that much at it.. it has > >> always had a nasty habit of biting back when you make a lot of changes :-D > >> > >> I know my version has worked for quite some time in my testing so I brought it back. > >> Complete with its 3 return codes (I only recently switched to your version and thus > >> started having difficulties with leaks and crashes)…. > >> > >> You are welcome not to use this.. I know it works (it ran > >> on a number of machines at NF last night.. and we will of course continue testing > >> it as we finish our dev testing for the upcoming OCA software release).. For now > >> this is what will be going out into the OCA’s at least :-) > >> > > > > I'm honestly done with this topic, and at the point now where I'm > > considering backing out all changes to callout(9) and related changes to > > the state they were at in stable/10. > > > > This changes the KBI, and if it needs to be done, it needs to happen > > now. We cannot wait for RC1 phase for this, and the amount of churn to > > get things into a working state with the current implementation far > > outweighs the benefit of the dangers. > > > > Glen > > > > -------- > Randall Stewart > rrs@netflix.com > 803-317-4952 > > > > > [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXjjF+AAoJEAMUWKVHj+KTz4IP/RS7eMubuJFzIGlvByqZ0FFl UUEQrjRVG0VB9UTMOEW27zo8Xt1jj9iv1TyZJqgdadIZlBGaQiw5A5rotDAUTFTD RR+6QxRv32bxlwJlSb10fZaAbbUjG197OnwmzgBUTke5cqTm+5GZt9x6rUhaSjes H/sMP2lOtg2fUEKu7k7oONTqhwZFvusanoi4dbvYOLWQcah782bSycZugbMltfZB lQksNCDnJNXzW3L3aLqI0dGHHfxyBHpLgIaYBLJbocacu5gLJ4l2srFe3ab9QwGT fSG8Od3CDHNWRgxw4I2qfb20pShKNLrq9Tzwm+g7eAr1Vk5ssvz+viMlvhyJx5q2 U8NgZcZsvbaUMgLMXfJGG7nOLZN+G3U0QUzvt3/AO30ARP4iVdZUKhE9jffYvlPe 7BlyxQBFft0HoWpayI/4nYDQzknzDo7phfdqW2IpakcMu+tIu0ocnb8Zs1bz5kyh BX8r6MFZIMQmHG1pZh53XU+rONke1PVsq7zDOZLjR2MMKrsCEU9nW2O8ZQxO7Lsb uUyhfOlxn/n65LiL7NZrVExs6CzKDaMn5tAoJxhVMGoImvOCz97iWmTtTnXIJ9vE cq6oiPPGd72Rt4pogMiQ2lFFPOd4rwkW0GgX3p+n4hmM5tLaUt8daDJPh82AfhqF GUqCKdveifpNCXFrqL6T =yXdD -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160719135614.GE65494>