Date: Mon, 11 Apr 2005 00:40:21 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Hartmut Brandt <harti@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make cond.c cond.h for.c for.h parse.c parse.h Message-ID: <20050411074021.GA85675@xor.obsecurity.org> In-Reply-To: <200504110720.j3B7KAIx034955@repoman.freebsd.org> References: <200504110720.j3B7KAIx034955@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 11, 2005 at 07:20:10AM +0000, Hartmut Brandt wrote: > harti 2005-04-11 07:20:10 UTC >=20 > FreeBSD src repository >=20 > Modified files: > usr.bin/make cond.c cond.h for.c for.h parse.c parse.h=20 > Log: > Rework the directive parsing code. Instead of using a lot of strcmp()s > on every line that starts with a dot use a minimal perfect hash > function and a single strcmp() on the first word after the dot > to find out whether it is really a directive call and, if yes, which > one. Then directly dispatch to a handler function for that directive > (or fall through to the dependency handling code). This makes the > directive parse a little bit more strict about the syntax: the directive > word must be followed by a character that is not alphanumerical and not > an underline (making .undefFOO illegal); .endif and .else can only be > followed by comments. I assume you've tested that this doesn't cause problems for anything in the ports collection? Kris --FL5UXtIhxfXey3p5 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFCWinkWry0BWjoQKURAsG+AKDCa8MAzW1GHrXfqY0udrsvj9XvdwCfXzaJ TU9QdUdBvkL1I5+K0FwzvwY= =6Bdl -----END PGP SIGNATURE----- --FL5UXtIhxfXey3p5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050411074021.GA85675>