Date: Tue, 5 Jul 2016 12:29:39 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Dimitry Andric <dim@FreeBSD.org> Cc: freebsd-current@FreeBSD.org, Roman Divacky <rdivacky@FreeBSD.org> Subject: Re: FreeBSD_HEAD_amd64_gcc - Build #1340 - Still Failing Message-ID: <E647E4C6-CDB8-47C6-B446-03F192A96D07@gmail.com> In-Reply-To: <AB8350C8-7CEF-4559-828D-9D78BE7B24A6@gmail.com> References: <74935894.29.1467723929184.JavaMail.jenkins@jenkins-9.freebsd.org> <824400089.31.1467734600930.JavaMail.jenkins@jenkins-9.freebsd.org> <1A4CCE99-7039-404C-B177-1DA230AD8811@FreeBSD.org> <AB8350C8-7CEF-4559-828D-9D78BE7B24A6@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Jul 5, 2016, at 11:54, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > >> >> On Jul 5, 2016, at 11:52, Dimitry Andric <dim@FreeBSD.org> wrote: >> >> On 05 Jul 2016, at 18:03, jenkins-admin@freebsd.org wrote: >>> >>> FreeBSD_HEAD_amd64_gcc - Build #1340 - Still Failing: >>> >>> Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/ >>> Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/changes >>> Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/console >> ... >>> /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c: In function 'sse42_supported': >>> /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c:885:17: error: 'bit_SSE42' undeclared (first use in this function) >>> return ((ecx & bit_SSE42) != 0); >>> ^ >> >> So, this is because clang's and gcc's versions of cpuid.h use slightly different naming for these bits: >> >> clang's cpuid.h: >> >> #define bit_SSE41 0x00080000 >> #define bit_SSE42 0x00100000 >> >> gcc's cpuid.h: >> >> #define bit_SSE4_1 (1 << 19) >> #define bit_SSE4_2 (1 << 20) >> >> Unfortunately there are more bit defines that differ. No standardization on this point, it seems. :-/ >> >> For this specific compile error, we could put in a little crutch like: >> >> #if defined(bit_SSE4_2) && !defined(bit_SSE42) >> #define bit_SSE42 bit_SSE4_2 >> #endif >> >> Thoughts? > > Seems ok to me. I was going to submit a patch to fix the other issues with bhyve (because I am getting annoyed by the build failure emails). Actually, there’s a better #define: /usr/include/x86/specialreg.h:#define CPUID2_SSE41 0x00080000 Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXfAqkAAoJEPWDqSZpMIYVBEsQAIGbME5jpV3Z1/dITibrNZ/l TiYCCMEIcnw3VA/YguDOVicCVGwqVuuRmmjjukubb/JqyADjSlOUa22etzjGqp56 95kxoAFLxdqOC/2f0CsqNTMd39TWdwqRBKeqQjs1AJQQImqLYZzBnJRpzR1QsKaP eXtSENoF4u0uSKwOaj2p4ugmoN5OhqNJzr5XpTSHE71G+/9yH9VSCFldPKmlVa9k yJhFVIUdxSvH2R5+3K6IQ+9JQggk8wAWt3U6mmlrV4GEOQi1TtcPVHyUtaF/mXYK XFeeMeZ8iMNr+rhva7X9EBx/eGvHTb1X9DbiPjMx1BGBmO8a3bm7x0NLJGH1KO1K AZ6FpsOXVpRl6e5JxeMnUhN2ZuR+TazDi24nNT/5ryrmIwN8KIQhg6F+bzah9Jee iA2VstUOM4zSi7aXfVb50EGjC/Dysz80BGyjSaejfY/Uq1SkwOosC6WIFY+rRYVa I8SA2HVGrNbg3jTpSTFS4W5x1xBfUSiinSuQ50bzKyi+7sawhFFZ9UkQb+PB3Fyb H7L/2/Z75ZGhTWm2jN1vSbpyxSPMtGwESa+LmB71IdNnv9fVfxukGlDUfyQqAtRS r7prR7yyAcAQPnqmm82Ak/N5cE5NxsS6E3kyRZz4+eZ3IPD6QSqx3XdU0RwVF8wI 3d+IASf4KGn7VtBDa0ml =9xpV -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E647E4C6-CDB8-47C6-B446-03F192A96D07>