Date: Thu, 15 Aug 2002 13:34:47 -0400 (EDT) From: Robert Watson <rwatson@freebsd.org> To: Mike Heffner <mheffner@acm.vt.edu> Cc: freebsd-current@freebsd.org Subject: Re: panic: system call accept returning with mutex(s) held Message-ID: <Pine.NEB.3.96L.1020815133412.8976C-100000@fledge.watson.org> In-Reply-To: <Pine.NEB.3.96L.1020815133139.8976B-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Actually, I've gone ahead and committed the change, update to
uipc_syscalls.c:1.128 and see if the problem goes away. (if you do it by
hand locally, make sure to assign error = EINVAL before jumping).
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org Network Associates Laboratories
On Thu, 15 Aug 2002, Robert Watson wrote:
>
> Hmm. This could be my bug due to mixing up a -stable and a -current
> patch. I modified accept() to reject negative sockaddr name lengths, but
> it looks like I botched the return path:
>
> if (uap->name) {
> error = copyin(uap->anamelen, &namelen, sizeof (namelen));
> if(error)
> goto done2;
> if (namelen < 0)
> return (EINVAL);
> }
>
> Try turning that 'return (EINVAL);' into a 'goto done2;' and see if that
> helps.
>
> Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
> robert@fledge.watson.org Network Associates Laboratories
>
> On Thu, 15 Aug 2002, Mike Heffner wrote:
>
> > With -current from earlier this week, panics whenever I start
> > gaim. Didn't see anything similar in the archives. I'll be happy to
> > provide more information if needed.
> >
> > Mounting root from ufs:/dev/ad0s2a
> > exclusive sleep mutex Giant r = 0 (0xc02da9a0) locked @ ../../../kern/subr_trap.c:80
> > panic: system call accept returning with mutex(s) held
> >
> >
> > syncing disks... panic: bremfree: bp 0xc3c32ee4 not locked
> > Uptime: 3m18s
> > pfs_vncache_unload(): 1 entries remaining
> > Dumping 127 MB
> > ata0: resetting devices ..
> > done
> > 16 32 48 64 80 96 112
> > ---
> > #0 doadump () at ../../../kern/kern_shutdown.c:213
> > 213 dumping++;
> > (kgdb) bt
> > #0 doadump () at ../../../kern/kern_shutdown.c:213
> > #1 0xc01aaa86 in boot (howto=260) at ../../../kern/kern_shutdown.c:345
> > #2 0xc01aaca3 in panic () at ../../../kern/kern_shutdown.c:493
> > #3 0xc01dfc47 in bremfree (bp=0xc02b0f05) at ../../../kern/vfs_bio.c:633
> > #4 0xc01e1668 in vfs_bio_awrite (bp=0xc1525840) at ../../../kern/vfs_bio.c:1627
> > #5 0xc022e991 in ffs_fsync (ap=0xc8e7bc1c) at ../../../ufs/ffs/ffs_vnops.c:231
> > #6 0xc022df8e in ffs_sync (mp=0xc1471400, waitfor=2, cred=0xc0babe00, td=0xc02d6480)
> > at vnode_if.h:545
> > #7 0xc01f162c in sync (td=0xc02d6480, uap=0x0) at ../../../kern/vfs_syscalls.c:129
> > #8 0xc01aa6a2 in boot (howto=256) at ../../../kern/kern_shutdown.c:254
> > #9 0xc01aaca3 in panic () at ../../../kern/kern_shutdown.c:493
> > #10 0xc027d8a2 in syscall (frame=
> > {tf_fs = 47, tf_es = 47, tf_ds = 47, tf_edi = 135554112, tf_esi = 135604464, tf_ebp = -1077940868, tf_isp = -924336780, tf_ebx = 673945180, tf_edx = 1, tf_ecx = 0, tf_eax = 22, tf_trapno = 12, tf_err = 2, tf_eip = 676290179, tf_cs = 31, tf_eflags = 663, tf_esp = -1077941024, tf_ss = 47}) at ../../../i386/i386/trap.c:1120
> > #11 0xc026e76d in Xint0x80_syscall () at {standard input}:140
> >
> >
> > FreeBSD 5.0-CURRENT #1: Wed Aug 14 12:19:54 EDT 2002
> > spock@satellite.muriel.penguinpowered.com:/usr/src/sys/i386/compile/SATELLIT
> > E
> > Preloaded elf kernel "/boot/kernel/kernel" at 0xc03ff000.
> > Preloaded elf module "/boot/kernel/random.ko" at 0xc03ff0a8.
> > Preloaded elf module "/boot/kernel/acpi.ko" at 0xc03ff154.
> > Timecounter "i8254" frequency 1193182 Hz
> > Timecounter "TSC" frequency 746339059 Hz
> > CPU: Pentium III/Pentium III Xeon/Celeron (746.34-MHz 686-class CPU)
> > Origin = "GenuineIntel" Id = 0x686 Stepping = 6
> > Features=0x383f9ff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,SEP,MTRR,PGE,MCA,CMOV,PA
> > T,PSE36,MMX,FXSR,SSE>
> > real memory = 134086656 (130944K bytes)
> > avail memory = 125779968 (122832K bytes)
> >
> >
> > Mike
> >
> > --
> >
> > Mike Heffner <mheffner@[acm.]vt.edu>
> > <mikeh@FreeBSD.org>
> >
> >
> > To Unsubscribe: send mail to majordomo@FreeBSD.org
> > with "unsubscribe freebsd-current" in the body of the message
> >
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-current" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1020815133412.8976C-100000>