Date: Mon, 29 Jan 2018 09:46:02 -0800 From: John Baldwin <jhb@freebsd.org> To: Michal Meloun <mmel@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328511 - head/sys/dev/extres/clk Message-ID: <4499401.WAFztV9qgp@ralph.baldwin.cx> In-Reply-To: <201801281520.w0SFKjQe067446@repo.freebsd.org> References: <201801281520.w0SFKjQe067446@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, January 28, 2018 03:20:45 PM Michal Meloun wrote: > Author: mmel > Date: Sun Jan 28 15:20:45 2018 > New Revision: 328511 > URL: https://svnweb.freebsd.org/changeset/base/328511 > > Log: > diff --git a/sys/dev/extres/clk/clk.c b/sys/dev/extres/clk/clk.c > index c6a1f466ceb..c3708a0ce27 100644 > --- a/sys/dev/extres/clk/clk.c > +++ b/sys/dev/extres/clk/clk.c > @@ -642,10 +642,11 @@ clknode_adjust_parent(struct clknode *clknode, int idx) > if (clknode->parent_cnt == 0) > return; > if ((idx == CLKNODE_IDX_NONE) || (idx >= clknode->parent_cnt)) > - panic("Invalid clock parent index\n"); > + panic("%s: Invalid parent index %d for clock %s", > + __func__, idx, clknode->name); > > if (clknode->parents[idx] == NULL) > - panic("%s: Attempt to set invalid parent %d for clock %s", > + panic("%s: Invalid parent index %d for clock %s", > __func__, idx, clknode->name); > > /* Remove me from old children list. */ > @@ -674,8 +675,8 @@ clknode_init_parent_idx(struct clknode *clknode, int idx) > if ((idx == CLKNODE_IDX_NONE) || > (idx >= clknode->parent_cnt) || > (clknode->parent_names[idx] == NULL)) > - panic("%s: Invalid clock parent index: %d\n", __func__, idx); > - > + panic("%s: Invalid parent index %d for clock %s", > + __func__, idx, clknode->name); > clknode->parent_idx = idx; > } > > Modified: > head/sys/dev/extres/clk/clk.c Can you revert and recommit this with a proper log message? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4499401.WAFztV9qgp>