Date: Wed, 20 Oct 2010 08:38:44 +0400 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Marcel Moolenaar <xcllnt@mac.com> Cc: FreeBSD Current <freebsd-current@FreeBSD.ORG>, d@delphij.net Subject: Re: [zfs] Mounting from (...) failed with error 19 Message-ID: <4CBE7254.5060502@yandex.ru> In-Reply-To: <023E61D3-7E4C-4793-95A0-088ABCD0F92F@mac.com> References: <4CBCDD3A.9070404@delphij.net> <4CBD26B4.2020205@yandex.ru> <4CBDB17C.4040607@yandex.ru> <44B33168-C432-4AA0-A765-8222DB4C048D@mac.com> <4CBE0BE5.2060708@delphij.net> <023E61D3-7E4C-4793-95A0-088ABCD0F92F@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 20.10.2010 2:33, Marcel Moolenaar wrote: >> What about the attached patch? I'm going to give it a swirl soon. The >> difference is that it tests whether dev begins with /dev/. > > Interesting. I've been thinking about this too, but isn't > exactly fool-proof. When devfs is the root file system, > you can use "ufs:da0s1a" to refer to the device special > file. It seems inconsistent to have "ufs:da0s1" fail when > ufs:/dev/da0s1" works (a real scenario with USB based mass > storage devices -- root mount is unheld as soon as umass > is created, but before daX exists for it). > > This patch at least covers the problem cases with a single > strstr(), and we may get away with the inconsistency given > above by documenting it properly. > > Andrey: any thoughts? Currently usage information in parse_dir_ask() says that device should be specified with "/dev/". But conf0 does not use "/dev/". Also, Marcel, do you have any plans write some documentation with examples about using of new features? -- WBR, Andrey V. Elsukov [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJMvnJZAAoJEAHF6gQQyKF6q3MIAIk2x7atebcX/PrMJ7bByyWC tlES0gH8EUoKMwbuuSENj+2H3u5+MdOS/PFfdert9O4W8PASt7cjjNk86BseW6dN 1WKoXj7nGlhI9K3PcLzQGvfshjTeowPShzL8MmzlAPyeH2CFaUggYe2fgBMiH16R O2TbxT6oVFm+ctOETANlF+MNfK+uNrNXgCl2AwzmluxAoCzBg55S2/hqw+w21ej/ P1bP6mww5aEKz9pzNSvJmCo+271Y24uwZqpvkt+h5EofrTXumGmbTIKYMho95oJ2 ICG3WIvH7sO9w+B2bNi9znFjki+QIAO6NDBFNNrWI0Qi0gwWAFbKw7+EoEx4H5s= =PzCL -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CBE7254.5060502>