Date: Wed, 21 Sep 2005 10:41:46 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 84041 for review Message-ID: <200509211041.j8LAfk0o039977@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=84041 Change 84041 by rwatson@rwatson_zoo on 2005/09/21 10:41:24 In fstat(), audit the file descriptor rather than the vnode, since not all file descriptors have vnodes, and we want to know about the object represented by the file descriptor. Raises interesting questions for things that have vnodes and are non-vnodes. I.e., fifos. Affected files ... .. //depot/projects/trustedbsd/audit3/sys/kern/kern_descrip.c#8 edit Differences ... ==== //depot/projects/trustedbsd/audit3/sys/kern/kern_descrip.c#8 (text+ko) ==== @@ -1090,8 +1090,7 @@ if ((error = fget(td, fd, &fp)) != 0) return (error); - //XXX Grab the vnode lock? - AUDIT_ARG(vnpath, fp->f_vnode, ARG_VNODE1); + audit_arg_file(td->td_proc, fp); error = fo_stat(fp, sbp, td->td_ucred, td); fdrop(fp, td);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200509211041.j8LAfk0o039977>