Date: Wed, 12 Mar 2008 11:15:53 +0100 From: Pav Lucistnik <pav@FreeBSD.org> To: Alexander Leidinger <Alexander@leidinger.net> Cc: emulation@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.port.mk bsd.port.subdir.mk bsd.xorg.mk Message-ID: <1205316953.51779.13.camel@pav.hide.vol.cz> In-Reply-To: <20080312110416.rvewfpfrqcgswo0c@webmail.leidinger.net> References: <200803112345.m2BNj4Hj051138@repoman.freebsd.org> <20080312110416.rvewfpfrqcgswo0c@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Alexander Leidinger píše v st 12. 03. 2008 v 11:04 +0100: > Quoting Pav Lucistnik <pav@FreeBSD.org> (from Tue, 11 Mar 2008 > 23:45:04 +0000 (UTC)): > > > - Teach USE_LDCONFIG to do the right thing when used with USE_LINUX_PREFIX > > > > PR: ports/118212 > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=118212 > > Original patch: vd > > Patch by: pav > > I would like to know why emulation@ was not in the loop for this. > > At > http://www.leidinger.net/FreeBSD/port-patches/Mk:bsd.port.mk.diff I wasn't aware of this patch. Is it mentioned in a PR assigned to portmgr anywhere? If I ignore not-ldconfig related changes in your patch, the functionality should be equivalent. I do not need to set NO_LDCONFIG_MTREE, because that code branch is never reached. My code goes like if (linux) { do linux stuff } else { do native stuff } Your code went like if (linux) { setup some variables } else { setup some variables} endif; do { common stuff }. Only difference I see is that you condition the use of linux mdconfig by presence of USE_LINUX, I need USE_LINUX_PREFIX, which is more strict, I think. -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> Just because you're an angel doesn't mean you have to be a fool. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEABECAAYFAkfXrVkACgkQntdYP8FOsoKsAACgs0csguqH0LVglhAIfYjQF2+E dtgAnjZZs9A1GN+wW6zQN0fam8wp7znp =ezMQ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1205316953.51779.13.camel>