Date: Fri, 13 Aug 2004 10:30:11 +0200 From: Bartosz Fabianowski <freebsd@chillt.de> To: NAKATA Maho <chat95@mac.com> Cc: openoffice@FreeBSD.org Subject: Re: openoffice-1.1 build more broken than usual on 5.2-CURRENT Message-ID: <411C7C13.7040101@chillt.de> In-Reply-To: <20040813.164228.730632177.chat95@mac.com> References: <200408120500.i7C50GIK019140@gw.catspoiler.org> <411B7593.5050907@chillt.de> <20040813.164228.730632177.chat95@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> Hmm I suggest a solution for it.
> How about it?
> change Makefile.mozilla
>
> @cd ${WRKDIR}/mozilla ; ${MAKE} CXX="${CXX}" CC="${CC}" CFLAGS_FROM_MAIN="${CFLAGS}" USE_GCC=${USE_GCC} build WRKDIRPREFIX=""
This way, you can pass CFLAGS to the sub port without breaking the sub
port, I agree.
However, first of all, I still don't see the reason for doing so. The
main port does not generate or change CFLAGS in any way, they are
determined solely by the ports framework. Since mozilla is built by a
sub port, this sub port will get the same treatment from the ports
framework and IMHO come up with the exact same CFLAGS by itself anyway.
Second, even if you pass CFLAGS inside a variable CFLAGS_FROM_MAIN, the
sub port won't use them. It does not know about the variable and thus
doesn't use it.
And finally, if you really want to pass CFLAGS down to the sub port,
would MAKE_ENV not be a better way of doing things?
- Bartosz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?411C7C13.7040101>