Date: Fri, 20 Apr 2007 14:34:54 +0000 (UTC) From: Andre Oppermann <andre@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c tcp_var.h Message-ID: <200704201434.l3KEYsX1022078@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
andre 2007-04-20 14:34:54 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c tcp_syncache.c tcp_var.h
Log:
Remove bogus check for accept queue length and associated failure handling
from the incoming SYN handling section of tcp_input().
Enforcement of the accept queue limits is done by sonewconn() after the
3WHS is completed. It is not necessary to have an earlier check before a
connection request enters the SYN cache awaiting the full handshake. It
rather limits the effectiveness of the syncache by preventing legit and
illegit connections from entering it and having them shaken out before we
hit the real limit which may have vanished by then.
Change return value of syncache_add() to void. No status communication
is required.
Revision Changes Path
1.338 +10 -16 src/sys/netinet/tcp_input.c
1.114 +2 -2 src/sys/netinet/tcp_syncache.c
1.143 +1 -1 src/sys/netinet/tcp_var.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704201434.l3KEYsX1022078>