Date: Tue, 30 Jun 2009 21:22:57 -0500 From: Brooks Davis <brooks@FreeBSD.org> To: Ken Smith <kensmith@cse.Buffalo.EDU> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, marc@msys.ch, svn-src-head@FreeBSD.org, mbr@FreeBSD.org, "M. Warner Losh" <imp@bsdimp.com> Subject: Re: svn commit: r195200 - in head/usr.sbin: . wake Message-ID: <20090701022257.GA9820@lor.one-eyed-alien.net> In-Reply-To: <1246413402.70460.23.camel@bauer.cse.buffalo.edu> References: <0E6D4FB2-A485-40ED-A856-ACC311A90EFE@msys.ch> <20090630.141340.289711551.imp@bsdimp.com> <7B9C309F-63E3-4CB8-9871-DE2DEE010096@msys.ch> <20090630.164009.2130804684.imp@bsdimp.com> <1246413402.70460.23.camel@bauer.cse.buffalo.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 30, 2009 at 09:56:42PM -0400, Ken Smith wrote: > On Tue, 2009-06-30 at 16:40 -0600, M. Warner Losh wrote: > > I hate to be blunt, but this leaves a bad taste in everybody's mouth, > > even if at the end of the day you get your way. >=20 > The second thing that left a bad taste in some peoples' mouth is that > this apparently (strictly judging by the fallout discussions) didn't get > as much peer review as some people would have liked. Normally some > level of discussion happens on some public mailing lists (not private > email among a few potentially interested parties). And even after that > happens and the commit gets made there is some time for fallout > discussions to happen. Depending on the results of those potentially > lengthy discussions it might wind up being backed out. But because of > the stage of the release cycle we're in me having approved this can be > viewed as short-circuiting the normal public review because odds are it > will wind up staying despite some peoples' opinions due to the stage of > the release cycle we're in. Given that it doesn't make any significant difference if it makes it into the base for 8.0 (especially given that ports are still open). I'd say the only right course of action is to back it out. I personally wouldn't be surprised if some form of it made it in to a future release, but basically nothing was right with this commit (zero prior discussion, contained trivial bugs, last minute addition). -- Brooks --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFKSsiAXY6L6fI4GtQRAil/AKDR78c4bMcxmDVlFmSB2KN5E/yLHwCfQtds 57HUOLBavjw7+9BHNcM+Rxc= =3kiL -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090701022257.GA9820>