Skip site navigation (1)Skip section navigation (2) 
Date:      Mon, 29 Jul 2024 19:02:30 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        =?UTF-8?B?5YaF6Jek56WQ5LiA6YOO?= <naito.yuichiro@gmail.com>
Cc:        FreeBSD Current <freebsd-current@freebsd.org>
Subject:   Re: lua loader failes
Message-ID:  <CANCZdfpiCvLd8kRRGC_k3BOu0dmXfonK3qwGDJhT-F5QPwjJAQ@mail.gmail.com>
In-Reply-To: <32DC8FB2-1384-4F15-8232-2606CCAD358E@gmail.com>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
Yes. My fault. I'll fix. I thought I'd tested the menu... but apparently
not. My apologies.

Warner

On Mon, Jul 29, 2024, 6:44 PM 内藤祐一郎 <naito.yuichiro@gmail.com> wrote:

> Hi, I updated my FreeBSD current machine to the following commit.
>
> FreeBSD vega.yuisoft.com 15.0-CURRENT FreeBSD 15.0-CURRENT #29
> main-n271492-0eac99f76ec3: Tue Jul 30 08:59:51 JST 2024
>  yuichiro@vega.yuisoft.com:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG
> amd64
>
> The lua loader fails as follows.
>
> ERROR: error loading module 'menu' from file '/boot/lua/menu.lua':
>   /boot/lua/menu.lua:420: '}' expected (to close '{' at line 415) near 'vi
> sible’.
>
> A comma is probably missing. The following patch works for me.
>
> diff --git a/stand/lua/menu.lua b/stand/lua/menu.lua
> index 66d7fe673023..7d295eeb65eb 100644
> --- a/stand/lua/menu.lua
> +++ b/stand/lua/menu.lua
> @@ -416,7 +416,7 @@ menu.welcome = {                          entry_type =
> core.MENU_SEPARATOR,
>                         name = function()
>                                 return "Loader requires updating"
> -                       end
> +                       end,
>                         visible = function()
>                                 return core.loaderTooOld()
>                         end
>
>
> —
> Yuichiro NAITO
> naito.yuichiro@gmail.com
>
>
>
>
>

[-- Attachment #2 --]
<div dir="auto">Yes. My fault. I&#39;ll fix. I thought I&#39;d tested the menu... but apparently not. My apologies. <div dir="auto"><br></div><div dir="auto">Warner </div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 29, 2024, 6:44 PM 内藤祐一郎 &lt;<a href="mailto:naito.yuichiro@gmail.com">naito.yuichiro@gmail.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi, I updated my FreeBSD current machine to the following commit.<br>
<br>
FreeBSD <a href="http://vega.yuisoft.com" rel="noreferrer noreferrer" target="_blank">vega.yuisoft.com</a> 15.0-CURRENT FreeBSD 15.0-CURRENT #29 main-n271492-0eac99f76ec3: Tue Jul 30 08:59:51 JST 2024     yuichiro@vega.yuisoft.com:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG amd64<br>
<br>
The lua loader fails as follows.<br>
<br>
ERROR: error loading module &#39;menu&#39; from file &#39;/boot/lua/menu.lua&#39;:          /boot/lua/menu.lua:420: &#39;}&#39; expected (to close &#39;{&#39; at line 415) near &#39;vi<br>
sible’.<br>
<br>
A comma is probably missing. The following patch works for me.<br>
<br>
diff --git a/stand/lua/menu.lua b/stand/lua/menu.lua<br>
index 66d7fe673023..7d295eeb65eb 100644<br>
--- a/stand/lua/menu.lua<br>
+++ b/stand/lua/menu.lua<br>
@@ -416,7 +416,7 @@ menu.welcome = {                          entry_type = core.MENU_SEPARATOR,<br>
                        name = function()<br>
                                return &quot;Loader requires updating&quot;<br>
-                       end<br>
+                       end,<br>
                        visible = function()<br>
                                return core.loaderTooOld()<br>
                        end<br>
<br>
<br>
—<br>
Yuichiro NAITO<br>
<a href="mailto:naito.yuichiro@gmail.com" target="_blank" rel="noreferrer">naito.yuichiro@gmail.com</a><br>
<br>
<br>
<br>
<br>
</blockquote></div>
help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpiCvLd8kRRGC_k3BOu0dmXfonK3qwGDJhT-F5QPwjJAQ>