Date: Mon, 22 Aug 2016 09:54:58 -0400 From: Allan Jude <allanjude@freebsd.org> To: Andriy Gapon <avg@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org, Toomas Soome <tsoome@FreeBSD.org> Subject: Re: svn commit: r303630 - in head/sys: boot/zfs cddl/boot/zfs Message-ID: <4139d778-9043-5f19-6f67-7f82ddfd9628@freebsd.org> In-Reply-To: <893dc513-69b4-ae9e-e3d3-2d2d02d04348@FreeBSD.org> References: <201608011937.u71JbhGD055117@repo.freebsd.org> <893dc513-69b4-ae9e-e3d3-2d2d02d04348@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kOtw74kS5Li2SL5h8sfvBk8sFLmJWROi9 Content-Type: multipart/mixed; boundary="6nVxB4FDblsDCmnnVu0mHXcDWv58MEPVV" From: Allan Jude <allanjude@freebsd.org> To: Andriy Gapon <avg@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org, Toomas Soome <tsoome@FreeBSD.org> Message-ID: <4139d778-9043-5f19-6f67-7f82ddfd9628@freebsd.org> Subject: Re: svn commit: r303630 - in head/sys: boot/zfs cddl/boot/zfs References: <201608011937.u71JbhGD055117@repo.freebsd.org> <893dc513-69b4-ae9e-e3d3-2d2d02d04348@FreeBSD.org> In-Reply-To: <893dc513-69b4-ae9e-e3d3-2d2d02d04348@FreeBSD.org> --6nVxB4FDblsDCmnnVu0mHXcDWv58MEPVV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-08-22 04:21, Andriy Gapon wrote: > On 01/08/2016 22:37, Allan Jude wrote: >> Author: allanjude >> Date: Mon Aug 1 19:37:43 2016 >> New Revision: 303630 >> URL: https://svnweb.freebsd.org/changeset/base/303630 >> >> Log: >> Make boot code and loader check for unsupported ZFS feature flags >> =20 >> OpenZFS uses feature flags instead of a zpool version number to trac= k >> features since the split from Oracle. In addition to avoiding confus= ion >> on ZFS vs OpenZFS version numbers, this also allows features to be a= dded >> to different operating systems that use OpenZFS in different order. >> =20 >> The previous zfs boot code (gptzfsboot) and loader (zfsloader) blind= ly >> tries to read the pool, and if failed provided only a vague error me= ssage. >> =20 >> With this change, both the boot code and loader check the MOS featur= es >> list in the ZFS label and compare it against the list of features th= at >> the loader supports. If any unsupported feature is active, the pool = is >> not considered as a candidate for booting, and a helpful diagnostic >> message is printed to the screen. Features that are merely enabled v= ia >> zpool upgrade, but not in use, do not block booting from the pool. >> =20 >> Submitted by: Toomas Soome <tsoome@me.com> >> Reviewed by: delphij, mav >> Relnotes: yes >> Differential Revision: https://reviews.freebsd.org/D6857 >=20 > It is really great to get a helpful diagnostic message when an unsuppor= ted > feature is seen. Thank you for that! >=20 > But I would prefer that the check is done on a filesystem level, not on= a pool > level. That is, I would like to be able to enable features that are no= t > supported by ZFS boot chain on a boot pool as long as I do not enable s= uch > features on a boot filesystem. E.g., the large blocks support could be= one of > such features. This was my though originally, but it is not as easy to tell if a filesystem has ever used a feature. For pool wide, it is just a property.= Do you know of an easy way to get this information for a specific file system? >=20 > And, as I've said in another email, I really do not think that we shoul= d strive > to support all possible (non-essential) ZFS features in the ZFS boot ch= ain. >=20 --=20 Allan Jude --6nVxB4FDblsDCmnnVu0mHXcDWv58MEPVV-- --kOtw74kS5Li2SL5h8sfvBk8sFLmJWROi9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJXuwQ1AAoJEBmVNT4SmAt+oMwQAI6NoFMgcgiiQYkUKOocuWhV OCQB7toclrfAUNJfMCKordgL3czlCLwS2H7Z1kd5OJMAysTTRgYQErZUTzWKHP/f FrEbFaP4lt47EGsgQI7Vten9r2LjBKcuDIOaa/EyG/RxIeF3Ywp28p2GMUwGQr4s p41I2oyg/2ss862v7aIKRPGxPQz0mX+EGVrN1CvyiyecD4mHJhXeWyNvw6d4HBYv SsAv3PMVGJ83agGXAzICTScD/K0YX7y5GzH/vc+Zhw1Jzbxiw5A9wZ+REUNKs79r 9dhqWYY+TCCcBU6+Ly/RFe8psxm3NLwUn1B1Hx+bpTfENxiBT2noEEoR5W614KQY Bo0EzsnZo9xLyBxl5GxikmNX/22J0+Bp/qhaDixG2Uo6MP0WllnpFKTxGXGvO1jR JJcmeKB6LdtT3Z21maR2X4z8+vZtgCHOTm3nrkTJictLidBxSiV5Xs9oOTpceEs/ O/slUS+9Wu7SJWtZG5dP77926xP6g7Y7ITsrdmwUAvH7c96hAKrAttjX859GOHCs JZC6chIgzpm9vvMQ2p1piJzIJftqt/kUqZuhp+9uz1kxMlofQblwY4aeMVAf0m1N j3jmO9OciU9/tbey8xxgVDhYfIXOaTRTJiqjDmGTI2DszrkTfPdSlcICkxLALijQ x0C6ymh/F1Fs2X90HGW8 =sSiy -----END PGP SIGNATURE----- --kOtw74kS5Li2SL5h8sfvBk8sFLmJWROi9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4139d778-9043-5f19-6f67-7f82ddfd9628>