Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 19 Sep 2010 10:47:16 +0100
From:      Rui Paulo <rpaulo@freebsd.org>
To:        pluknet <pluknet@gmail.com>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r212831 - head/lib/libproc
Message-ID:  <C572E7F6-5BD4-4E04-B68C-FFD1F8C48A05@freebsd.org>
In-Reply-To: <AANLkTikWYQGY%2By4nyXePG1mcPG578k3SK-mZJd4cebSQ@mail.gmail.com>
References:  <201009182338.o8INcLF8081790@svn.freebsd.org> <AANLkTikWYQGY%2By4nyXePG1mcPG578k3SK-mZJd4cebSQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help 
On 19 Sep 2010, at 09:01, pluknet wrote:

> On 19 September 2010 03:38, Rui Paulo <rpaulo@freebsd.org> wrote:
>> Author: rpaulo
>> Date: Sat Sep 18 23:38:21 2010
>> New Revision: 212831
>> URL: http://svn.freebsd.org/changeset/base/212831
>>=20
>> Log:
>>  Ignore EINTR when calling waitpid.
>>=20
>> Modified:
>>  head/lib/libproc/proc_util.c
>>=20
>> Modified: head/lib/libproc/proc_util.c
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/lib/libproc/proc_util.c        Sat Sep 18 22:37:47 2010      =
  (r212830)
>> +++ head/lib/libproc/proc_util.c        Sat Sep 18 23:38:21 2010      =
  (r212831)
>> @@ -145,7 +145,8 @@ proc_wstatus(struct proc_handle *phdl)
>>        if (phdl =3D=3D NULL)
>>                return (-1);
>>        if (waitpid(phdl->pid, &status, WUNTRACED) < 0) {
>> -               warn("waitpid");
>> +               if (errno !=3D EINTR)
>> +                       warn("waitpid");
>>                return (-1);
>>        }
>>        if (WIFSTOPPED(status))
>=20
> Hi.
>=20
> After this change the waitpid() error handling still doesn't
> ignore EINTR (well, only warn() ignores EINTR now),
> but it rather returns with -1. Is it intentional?
> I though something more like this was meant in svn log:
>=20
> while (waitpid(...) < 0)
>    if (errno !=3D EINTR) {
>        warn("waitpid");
>        return (-1);
>    }

Maybe the log was badly worded, but the code is right.


Regards,
--
Rui Paulo

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C572E7F6-5BD4-4E04-B68C-FFD1F8C48A05>