Date: Sun, 19 Jan 2020 10:10:28 -0700 From: Warner Losh <imp@bsdimp.com> To: Mateusz Guzik <mjg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r356883 - head/sys/kern Message-ID: <CANCZdfoYc6=XMv5=%2BJGsqMZQR3igiVVYBO-L04erpohe5zKxgw@mail.gmail.com> In-Reply-To: <202001191705.00JH5QRQ006755@repo.freebsd.org> References: <202001191705.00JH5QRQ006755@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 19, 2020, 10:05 AM Mateusz Guzik <mjg@freebsd.org> wrote: > Author: mjg > Date: Sun Jan 19 17:05:26 2020 > New Revision: 356883 > URL: https://svnweb.freebsd.org/changeset/base/356883 > > Log: > cache: counter_u64_add_protected -> counter_u64_add > > Fixes booting on RISC-V where it does happen to not be equivalent. > Any reason we can't just have a counter64 API that works the same both places rather than hiding what looks to my eye to be just that behind ifdefs in vfs_cache.c? Warner Reported by: lwhsu > > Modified: > head/sys/kern/vfs_cache.c > > Modified: head/sys/kern/vfs_cache.c > > ============================================================================== > --- head/sys/kern/vfs_cache.c Sun Jan 19 16:24:25 2020 (r356882) > +++ head/sys/kern/vfs_cache.c Sun Jan 19 17:05:26 2020 (r356883) > @@ -412,14 +412,14 @@ static void > cache_numcachehv_inc(void) > { > > - counter_u64_add_protected(numcachehv, 1); > + counter_u64_add(numcachehv, 1); > } > > static void > cache_numcachehv_dec(void) > { > > - counter_u64_add_protected(numcachehv, -1); > + counter_u64_add(numcachehv, -1); > } > #else > static void >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoYc6=XMv5=%2BJGsqMZQR3igiVVYBO-L04erpohe5zKxgw>