Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 12 Sep 2017 06:24:44 +0000 (UTC)
From:      Ryan Libby <rlibby@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r323486 - in stable/11/sys: amd64/include sys
Message-ID:  <201709120624.v8C6Oip4060938@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: rlibby
Date: Tue Sep 12 06:24:44 2017
New Revision: 323486
URL: https://svnweb.freebsd.org/changeset/base/323486

Log:
  MFC r321284:
  
    efi: restrict visibility of EFIABI_ATTR-declared functions

Modified:
  stable/11/sys/amd64/include/efi.h
  stable/11/sys/sys/efi.h
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/amd64/include/efi.h
==============================================================================
--- stable/11/sys/amd64/include/efi.h	Tue Sep 12 06:21:43 2017	(r323485)
+++ stable/11/sys/amd64/include/efi.h	Tue Sep 12 06:24:44 2017	(r323486)
@@ -36,8 +36,14 @@
  * XXX: from gcc 6.2 manual:
  * Note, the ms_abi attribute for Microsoft Windows 64-bit targets
  * currently requires the -maccumulate-outgoing-args option.
+ *
+ * Avoid EFIABI_ATTR declarations for compilers that don't support it.
+ * GCC support began in version 4.4.
  */
+#if defined(__clang__) || defined(__GNUC__) && \
+    (__GNUC__ > 4 || __GNUC__ == 4 && __GNUC_MINOR__ >= 4)
 #define	EFIABI_ATTR	__attribute__((ms_abi))
+#endif
 
 #ifdef _KERNEL
 struct uuid;

Modified: stable/11/sys/sys/efi.h
==============================================================================
--- stable/11/sys/sys/efi.h	Tue Sep 12 06:21:43 2017	(r323485)
+++ stable/11/sys/sys/efi.h	Tue Sep 12 06:24:44 2017	(r323486)
@@ -122,6 +122,9 @@ struct efi_tblhdr {
 	uint32_t	__res;
 };
 
+#ifdef _KERNEL
+
+#ifdef EFIABI_ATTR
 struct efi_rt {
 	struct efi_tblhdr rt_hdr;
 	efi_status	(*rt_gettime)(struct efi_tm *, struct efi_tmcap *)
@@ -144,6 +147,7 @@ struct efi_rt {
 	efi_status	(*rt_reset)(enum efi_reset, efi_status, u_long,
 	    efi_char *) EFIABI_ATTR;
 };
+#endif
 
 struct efi_systbl {
 	struct efi_tblhdr st_hdr;
@@ -163,7 +167,6 @@ struct efi_systbl {
 	uint64_t	st_cfgtbl;
 };
 
-#ifdef _KERNEL
 extern vm_paddr_t efi_systbl_phys;
 #endif	/* _KERNEL */

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201709120624.v8C6Oip4060938>