Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 May 2011 09:35:53 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        freebsd-current@freebsd.org
Cc:        current@freebsd.org, Andriy Gapon <avg@freebsd.org>
Subject:   Re: COUNT_IPIS vs CPU_FOREACH
Message-ID:  <201105090935.54264.jhb@freebsd.org>
In-Reply-To: <4DC512D6.9070904@FreeBSD.org>
References:  <4DC512D6.9070904@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday, May 07, 2011 5:37:26 am Andriy Gapon wrote:
> 
> I believe that the following change is needed to fix COUNT_IPIS option.
> Right now it seems to be a noop.
> 
> 
>     mp_ipi_intrcnt: CPU_FOREACH can't be used this early
> 
>     ... because all_cpus is not set yet.

Have you tested this?

all_cpus is set by start_all_aps() from cpu_mp_start() which runs at 
SI_SUB_CPU.   This SYSINIT runs later at SI_SUB_INTR.

So I think CPU_FOREACH() should be fine here.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201105090935.54264.jhb>