Date: Wed, 16 Jul 2014 13:29:14 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r268745 - in head/usr.bin: . timeout Message-ID: <20140716112914.GI48710@ivaldir.etoilebsd.net> In-Reply-To: <20140716104512.GB17076@dft-labs.eu> References: <201407160955.s6G9taro084054@svn.freebsd.org> <20140716102908.GA17076@dft-labs.eu> <20140716103411.GH48710@ivaldir.etoilebsd.net> <20140716104512.GB17076@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Jul 16, 2014 at 12:45:12PM +0200, Mateusz Guzik wrote:
> On Wed, Jul 16, 2014 at 12:34:11PM +0200, Baptiste Daroussin wrote:
> > On Wed, Jul 16, 2014 at 12:29:08PM +0200, Mateusz Guzik wrote:
> > > On Wed, Jul 16, 2014 at 09:55:36AM +0000, Baptiste Daroussin wrote:
> > > > +static void
> > > > +usage(void)
> > > > +{
> > > > + fprintf(stderr, "Usage: %s [--signal sig | -s sig] [--preserve-status]"
> > > > + " [--kill-after time | -k time] [--foreground] <duration> <command>"
> > > > + " <arg ...>\n", getprogname());
> > > > +
> > >
> > > Missing newline at the begnning.
> > New line at the beginning?
> > >
>
> static void
> usage(void)
> {
>
> fprintf(...);
Fixed
>
> > > > + exit(EX_USAGE);
> > > > +}
> > > > +
> > > > + switch(signo) {
> > > > + case 0:
> > >
> > > sig 0? I doubt it is ever delivered.
> >
> > one of the tests from the GNU testsuite is passing 0 signal
>
> I even checked. The kernel is not going to deliver signal 0, so checking
> for it in signal handler does not seem to make sense.
>
> Does the testcaes fail without it or something?
>
Yes the test fails without it
regards,
Bapt
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlPGYgoACgkQ8kTtMUmk6ExTCgCeN5OA5fQShU36A1SBW2uMuGWs
WogAnA1/LZ2Q+cSZ+JgehXJHFEwq8KyV
=Bxr+
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140716112914.GI48710>