Date: Wed, 23 Jan 2002 01:12:49 -0800 (PST) From: "Samuel J. Greear" <dragonk@evilcode.net> To: freebsd-gnats-submit@FreeBSD.org Subject: bin/34199: [PATCH] top(1) RES/rss display incorrect Message-ID: <200201230912.g0N9Cn694978@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 34199 >Category: bin >Synopsis: [PATCH] top(1) RES/rss display incorrect >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 23 01:20:01 PST 2002 >Closed-Date: >Last-Modified: >Originator: Samuel J. Greear >Release: 5.0-CURRENT >Organization: >Environment: FreeBSD larrikin.evilcode.net 5.0-CURRENT FreeBSD 5.0-CURRENT #2: Tue Jan 22 22:48:56 GMT 2002 root@larrikin.evilcode.net:/usr/src/sys/i386/compile/DK i386 >Description: Due to KSE changes in kern_proc.c (rev 1.101) the member of kinfo_proc, ki_rssize no longer needs to be munged after retrieval to be accurate. See /bin/ps/print.c, rev 1.50. "UPAGES as a constant is gone in KSE. We are going to have to trust and/or fix ki_rssize". Whitespace in attached patch is hosed, see: http://evilcode.net/patches/top-rss.diff >How-To-Repeat: >Fix: --- machine.c.orig Wed Jan 23 01:59:21 2002 +++ machine.c Wed Jan 23 01:59:57 2002 @@ -574,7 +574,7 @@ (PRIO_MIN - 1 - (PRI_MAX_REALTIME - pp->ki_pri.pri_level)) : (PRIO_MAX + 1 + pp->ki_pri.pri_level - PRI_MIN_IDLE))), format_k2(PROCSIZE(pp)), - format_k2(pagetok(pp->ki_rssize)), + format_k2(pp->ki_rssize), status, smpmode ? pp->ki_lastcpu : 0, format_time(cputime), >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201230912.g0N9Cn694978>