Date: Tue, 25 Nov 2025 21:46:58 +0900 From: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> To: Dag-Erling =?UTF-8?B?U23DuHJncmF2?= <des@FreeBSD.org> Cc: Mark Linimon <linimon@portsmon.org>, Warner Losh <imp@bsdimp.com>, Ankush Mondal <ankushmondal1y2t@gmail.com>, hackers@freebsd.org Subject: Re: [PATCH] df: correct BLOCKSIZE handling for -k to use 1K-blocks (290710) Message-ID: <20251125214658.eb1e0cdf9df97601b9e28de9@dec.sakura.ne.jp> In-Reply-To: <86h5ui7qd5.fsf@ltc.des.dev> References: <CAEw80_2bA-NgE_XF0KVr55PSUDGEQTWGE7t9rpxOhykY1MsSvA@mail.gmail.com> <CANCZdfo9XbAKcgtSw953hpwc9jegzPhaVtfk7DtYTKdoHRnkUg@mail.gmail.com> <1789299192.176069.1764023439861@privateemail.com> <20251125082605.0cb9ab55a2c71a415b575c41@dec.sakura.ne.jp> <86h5ui7qd5.fsf@ltc.des.dev>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 25 Nov 2025 04:17:26 +0100
Dag-Erling Smørgrav <des@FreeBSD.org> wrote:
> Tomoaki AOKI <junchoon@dec.sakura.ne.jp> writes:
> > The best way for code review with FreeBSD is Phablicator for me.
> > The accounts are managed by FreeBSD project (or FreeBSD foundation),
> > unlike github.
>
> The accounts are managed by the person you're replying to.
Ah, thanks for maintaining the services you all!
> > And works fine for me (with some difficulty, though,
> > on opening review with adding files, but it can be overcome).
>
> There is no difficulty if you use git-arc (from the freebsd-git-devtools
> port) like the committer's guide says you should.
I cannot use devel/arcanist, which is called from git-arc.sh, as
conflicting archivers/arc is pulled in by security/clamav.
So my only choice is using web UI.
And I'm not committing my local changes but stashing, as I'm not
a committer and committing into local branch is not mandatory for me.
I don't want n* number (in case src) to become different with official
repo by missingly committing into officially existing branch instead of
purely local one.
git diff (with -U999999 for Phabricator) does good job unless
any new files are added, but if anything are added, I need to
1. generate diff by git diff and manually add diffs for
added files
2. reverse with the patch by 1. (Of course, dry-run first)
3. `git stash --include-untracked` to make unrelated diffs
backed out
4. apply the patch of 1.
5. build (/ package for ports case) to be sure
6. `git stash --include-untracked` again to move the changes
into stash
7. `git stash show -p --include-untracked -U999999 > path_to_patch`
to obtain sanely applicable diff for Phabricator
8.`git stash pop` and reverse the patch of 6. to be sure.
9. `git stash pop` again to restore previous state without the patfh
10. apply the patch of 6. to restore actual previous state.
Diff generated with above procedure are always sanely accepted
by Phabricator web UI in my experience.
(Hand crafted patch are often rejected.)
Regards.
> DES
> --
> Dag-Erling Smørgrav - des@FreeBSD.org
--
Tomoaki AOKI <junchoon@dec.sakura.ne.jp>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20251125214658.eb1e0cdf9df97601b9e28de9>