Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 2 Oct 2022 04:29:53 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 5d6c09f86995 - stable/13 - hdaa_eld_dump: eliminate write only variable len
Message-ID:  <202210020429.2924TrpG058801@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=5d6c09f86995c57768a88556466356174aa6635c

commit 5d6c09f86995c57768a88556466356174aa6635c
Author:     Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-07-08 17:53:33 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-10-02 04:25:55 +0000

    hdaa_eld_dump: eliminate write only variable len
    
    Sponsored by:           Netflix
    
    (cherry picked from commit 557627dda9b015728a478e31348808356eb75c73)
---
 sys/dev/sound/pci/hda/hdaa.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sys/dev/sound/pci/hda/hdaa.c b/sys/dev/sound/pci/hda/hdaa.c
index 6cc873efb042..e0cfca10e014 100644
--- a/sys/dev/sound/pci/hda/hdaa.c
+++ b/sys/dev/sound/pci/hda/hdaa.c
@@ -605,7 +605,7 @@ hdaa_eld_dump(struct hdaa_widget *w)
 	struct hdaa_devinfo *devinfo = w->devinfo;
 	device_t dev = devinfo->dev;
 	uint8_t *sad;
-	int len, mnl, i, sadc, fmt;
+	int mnl, i, sadc, fmt;
 
 	if (w->eld == NULL || w->eld_len < 4)
 		return;
@@ -614,7 +614,6 @@ hdaa_eld_dump(struct hdaa_widget *w)
 	    w->nid, w->eld[0] >> 3, w->eld[2]);
 	if ((w->eld[0] >> 3) != 0x02)
 		return;
-	len = min(w->eld_len, (u_int)w->eld[2] * 4);
 	mnl = w->eld[4] & 0x1f;
 	device_printf(dev,
 	    "ELD nid=%d: CEA_EDID_Ver=%u MNL=%u\n",



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202210020429.2924TrpG058801>