Date: Sat, 6 Mar 2021 17:52:55 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Rainer Hurling <rhurlin@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r561652 - in head/databases: libgda5-mdb mdbtools mdbtools/files recutils Message-ID: <20210306175255.GA23648@FreeBSD.org> In-Reply-To: <b5c49b0c-0469-88f3-a709-103cb3e30ae9@gwdg.de> References: <202101151716.10FHGPeF016819@repo.freebsd.org> <20210306164305.GA32516@FreeBSD.org> <b5c49b0c-0469-88f3-a709-103cb3e30ae9@gwdg.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 06, 2021 at 06:39:23PM +0100, Rainer Hurling wrote: > Am 06.03.21 um 17:43 schrieb Alexey Dokuchaev: > > On Fri, Jan 15, 2021 at 05:16:25PM +0000, Rainer Hurling wrote: > >> New Revision: 561652 > >> URL: https://svnweb.freebsd.org/changeset/ports/561652 > >> > >> Log: > >> databases/mdbtools: Update to 0.9.1 > >> > >> - Switch to a new fork on Github > >> - Split NLS (gettext) as an option > >> - Remove gmdb2 GUI (will come back as own port) > >> > >> ... > >> Modified: head/databases/mdbtools/Makefile > >> @@ -1,8 +1,8 @@ > >> -# Created by: Anders Nordby <anders@fix.no> > > > > We typically keep these lines out of respect to the original port author > > and appreciation of their efforts. While they are optional for new ports, > > one should not remove them unless under explicit concent of that person. > > Did you obtain that from Anders? > > Yes, you are right. That should not have happened. I will try to be more > careful next time. It's okay, just put it back when you touch the Makefile next time, e.g. during upcoming 0.9.2 update (no need for separate gratuitous commit). > >> PORTNAME= recutils > >> PORTVERSION= 1.8 > >> +PORTREVISION= 1 > > > > You should've checked all consumer ports that they actually can build > > against updated port, no just merely bump port revision, even if this > > dependency is optional and disabled by default. There had been some > > changes in public API so `databases/recutils' failed to build with MDB > > option enabled. I've fixed the port in r567461 and enabled MDB by > > default so this breakage could be caught earlier next time. > > Arghh, that slipped through. > > I'm really sorry to have caused you so much trouble and extra work. It was not really *that* bad, no worries. :) As I've said, it is more exposed now; it's indeed kind of cumbersome to test all those off-by- default options in all the consumers. Keep up the good work! ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210306175255.GA23648>