Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Mar 1999 15:30:42 -0800 (PST)
From:      asami@FreeBSD.ORG (Satoshi - the Wraith - Asami)
To:        tom@eborcom.com
Cc:        freebsd-ports@FreeBSD.ORG
Subject:   Re: Problems with p5-* ports
Message-ID:  <199903302330.PAA45505@silvia.hip.berkeley.edu>
In-Reply-To: <19990330172006.A18680@eborcom.com> (message from Tom Hukins on Tue, 30 Mar 1999 17:20:06 %2B0100)
References:  <19990322162220.A6658@eborcom.com> <Pine.HPP.3.96.990322152834.10524C-100000@hp9000.chc-chimes.com> <19990330172006.A18680@eborcom.com>

next in thread | previous in thread | raw e-mail | index | archive | help
 * From: Tom Hukins <tom@eborcom.com>

 * I'd appreciate comments from the Ports Wraith on this. Is there any
 * chance of something like this finding its way into bsd.port.mk?

"Ports Wraith"? ;)

 * +.if defined(PERL5_MODULE)
 * +MAN3PREFIX?=	${PREFIX}/lib/perl5/${PERL_VERSION}
 * +USE_PERL5=	yes
 * +.endif
 * +

Good.

 * +.if defined(PERL5_MODULE)
 * +	@(cd ${WRKSRC} && \
 * +	${SETENV} ${MAKE_ENV} ${PERL} Makefile.PL PREFIX=${PREFIX} \
 * +		INSTALLMAN1DIR=${PREFIX}/man/man1 \
 * +		INSTALLSCRIPT=${PREFIX}/bin)
 * +.endif

I'm not sure if this is good.  I've seen many different combinations
of settings, and some USE_PERL5 ports don't even have this line.

 *  .if make(real-extract)
 * +	@cd ${.CURDIR} && ${MAKE} ${.MAKEFLAGS} build-depends lib-depends perl5-depends misc-depends
 *  .if make(real-install)
 * +	@cd ${.CURDIR} && ${MAKE} ${.MAKEFLAGS} run-depends lib-depends perl5-depends

Ok.

 * +perl5-depends:
 * +.if defined(PERL5_DEPENDS)
 * +.if !defined(NO_DEPENDS)
 * +	@for i in ${PERL5_DEPENDS}; do \
 * +		lib=`${ECHO} $$i | ${SED} -e 's/\..*//' | ${SED} -e 's!/!::!g'`; \
 * +		version=`${ECHO} $$i | ${SED} -e 's/[^\.]*\.//' | ${SED} -e 's/:.*//'`; \
 * +		dir=`${ECHO} $$i | ${SED} -e 's/[^:]*://'`; \

Where's "target" defined?  (Did you test this patch?)

 * +			${ECHO_MSG} "===>    Verifying $$target for $$lib in $$dir"; \

I don't know perl jargon but the rest looks ok.

-PW


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903302330.PAA45505>