Date: Wed, 23 May 2001 22:48:21 +0200 (CEST) From: dan@obluda.cz To: FreeBSD-gnats-submit@freebsd.org Subject: kern/27598: SMB complain about SMP Message-ID: <200105232048.f4NKmL000775@xkulesh.vol.cz>
next in thread | raw e-mail | index | archive | help
>Number: 27598
>Category: kern
>Synopsis: netsmb can't be kldloaded in SMP environment
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed May 23 13:50:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator: Dan Lukes
>Release: FreeBSD 4.3-STABLE i386
>Organization:
Obludarium
>Environment:
System: FreeBSD xkulesh.vol.cz 4.3-STABLE FreeBSD 4.3-STABLE #18: Wed May 23 21:18:28 CEST 2001 dan@xkulesh.vol.cz:/usr/src/sys/compile/Dan i386
SMP hardware, SMP kernel, LIBICONV compiled in kernel,
kldloaded libmchain
STABLE CVSUPped od May 22
>Description:
when I use kldload smbfs, the following messages appear on console:
---------
error: module compiled without SMP support
netsmb_dev: unloaded
module_register_init: MOD_LOAD (dev_netsmb, c0c251a0, 0) error 1
error: module compiled without SMP support
---------
despite of it, smbfs is loaded
>How-To-Repeat:
see environment and description
>Fix:
I'm not sure about correct fix, because I'm not sure if netsmb
and/or smbfs is SMP sensitive and SMP ready.
sys/netsmb/smb_dev.c call the smb_checksmp() which is implemented
in sys/netsmb/smb_subr.c
smb_subr.c use SMP variable (#define), but doesn't #include
opt_global.h where SMP is defined
No file in sys/netsmb nor sys/fs/smbfs seems to contain a SMP specific
code other than (ever failing) test (there are no code using number of CPU's
nor ifdef-ed with SMP variable).
So, there are three posibilities:
1. netsmb/smbfs isn't SMP sensitive
- lets completelly remove redundant test
2. netsmp/smbfs is SMP sensitive, but not SMP ready
- lets change error message to something more true
3. netsmp/smbfs is SMB sensitive and is SMP ready (and I miss something)
- lets include opt_global.h to (at least) smb_subr.c
it give chance to test to work properly
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105232048.f4NKmL000775>