Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Jun 2017 23:12:10 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 207681] [libc] re-enable regex bayer-moore for the general multibyte case
Message-ID:  <bug-207681-8-QwneqhWtfl@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-207681-8@https.bugs.freebsd.org/bugzilla/>
References:  <bug-207681-8@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207681

Yuri Pankov <yuripv@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yuripv@gmx.com

--- Comment #2 from Yuri Pankov <yuripv@gmx.com> ---
I *think* you are reading the code wrong, see how regexec.c includes engine=
.c
several times, after setting different defines. With MNAMES defined, which
defines the proper XMBRTOWC, we have a "#define matcher mmatcher", and
regexec.c has the following in regexec():

        if (MB_CUR_MAX > 1)
                return(mmatcher(g, string, nmatch, pmatch, eflags));


So in multibyte case, we are using the mmatcher(), which gets defined along
with MNAMES and proper XMBRTOWC pointing to xmbrtowc() and not
xmbrtowc_dummy().

The man page bit talks specifically about *word boundaries* in multibyte
locales, not general multibyte case.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207681-8-QwneqhWtfl>