Date: Sun, 9 Feb 2003 23:12:44 -0500 From: Mike Makonnen <mtm@identd.net> To: Tim Robbins <tjr@freebsd.org> Cc: phk@phk.freebsd.dk, current@freebsd.org Subject: Re: MSDOSFS wastes 256k when nothing is mounted! Message-ID: <20030210041249.VPEI7656.out002.verizon.net@kokeb.ambesa.net> In-Reply-To: <20030210133148.A17199@dilbert.robbins.dropbear.id.au> References: <31456.1044819599@critter.freebsd.dk> <20030209230848.VZI7113.pop015.verizon.net@kokeb.ambesa.net> <20030210133148.A17199@dilbert.robbins.dropbear.id.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 10 Feb 2003 13:31:48 +1100 Tim Robbins <tjr@freebsd.org> wrote: > > hashinit() can sleep, and I don't think it's safe to sleep here > (msdosfs_hashget() and msdosfs_hashins()) with dehash_mtx and > sometimes a vnode lock held. Doh! I should have noticed that. > > It might be better to initialise the table the first time an > msdosfs filesystem is mounted. > Sounds reasonable enough. So, maybe allocate it in msdosfs_mount or mountmsdosfs and deallocate it in msdosfs_unmount? If there isn't an easy way to tell if you're on the last mounted msdos filesystem, it might be better to just leave the deallocation in msdosfs_uninit. Is that basically what you're saying? Cheers. -- Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc mtm@identd.net | Fingerprint: D228 1A6F C64E 120A A1C9 A3AA DAE1 E2AF DBCC 68B9 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030210041249.VPEI7656.out002.verizon.net>