Date: Tue, 20 Nov 2007 15:31:32 +0100 From: Max Laier <max@love2party.net> To: freebsd-net@freebsd.org Cc: JINMEI Tatuya / =?utf-8?q?=E7=A5=9E=E6=98=8E=E9=81=94=E5=93=89?= <jinmei@isl.rdc.toshiba.co.jp> Subject: Re: a format error in pf_print_host() Message-ID: <200711201531.41579.max@love2party.net> In-Reply-To: <m2ejelypa0.wl%jinmei@isl.rdc.toshiba.co.jp>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tuesday 20 November 2007, JINMEI Tatuya / 神明達哉 wrote: > (This should probably be reported to an OpenBSD forum, but I'm not > subscribing to any of the lists, so I'm posting this to freebsd-net. > I believe pf maintainers watch this list, too...) > > I've found a minor error in pf_print_host() which is revealed for some > time of IPv6 addresses. This routine always (perhaps unintentionally) > assumes abbreviate-able consecutive zero's, so, for example, it > formats "1:2:3:4:5:6:7:8" as ":2:3:4:5:6:7:8". This can be confirmed > by the sample code attached to this message by > - saving the file as e.g. "foo.c" > - cc -o foo foo.c > - ./foo 1:2:3:4:5:6:7:8 > > I've also attached a proposed patch to this problem. The diff was > made against 6-STABLE, but it's probably applicable to other versions. Seems your diff got lost during transmission, could you resend - please? -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHQu/NXyyEoT62BG0RAh/VAJ4jz5NVsCkCYbuAkdY0/BZTGrdgYQCdE9zz kE9CHkhouLeiJjgCUfWLtZE= =U3Th -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200711201531.41579.max>