Date: Mon, 15 Nov 2010 12:51:48 +1300 From: Andrew Thompson <thompsa@FreeBSD.org> To: Gavin Atkinson <gavin@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215319 - head/sys/arm/xscale/ixp425 Message-ID: <AANLkTikYTE5f9dUmVySt_bRtAp-gQ4nPYe5S4ZQUQVNm@mail.gmail.com> In-Reply-To: <alpine.LNX.2.00.1011142254160.23661@ury.york.ac.uk> References: <201011142041.oAEKfN6Y093321@svn.freebsd.org> <alpine.LNX.2.00.1011142254160.23661@ury.york.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 November 2010 11:56, Gavin Atkinson <gavin@freebsd.org> wrote: > On Sun, 14 Nov 2010, Andrew Thompson wrote: > >> Author: thompsa >> Date: Sun Nov 14 20:41:22 2010 >> New Revision: 215319 >> URL: http://svn.freebsd.org/changeset/base/215319 >> >> Log: >> =A0 Provide a mutex around the read/modify/write of the IXP425_GPIO_* >> =A0 registers. Giant was used in some places, but not all. > > I believe this should fix my PR arm/134338, but don't have the bandwidth > at the moment to verify that. =A0Is there any chance you could see if you > believe the same? It is essentially the same. I have not added locks around the probe/attach routines as interrupts/scheduler are still disabled. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikYTE5f9dUmVySt_bRtAp-gQ4nPYe5S4ZQUQVNm>