Date: Thu, 29 Jun 2006 18:07:42 -0500 From: "Christian S.J. Peron" <csjp@FreeBSD.org> To: Yar Tikhiy <yar@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient bootp_subr.c Message-ID: <44A45D3E.2040004@FreeBSD.org> In-Reply-To: <200606291537.k5TFbeUg075956@repoman.freebsd.org> References: <200606291537.k5TFbeUg075956@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Yar Tikhiy wrote: > yar 2006-06-29 15:37:39 UTC > > FreeBSD src repository > > Modified files: > sys/nfsclient bootp_subr.c > Log: > Use the elegant TAILQ_FOREACH() in place of a hand-rolled for() loop. > > Revision Changes Path > 1.65 +1 -3 src/sys/nfsclient/bootp_subr.c > > > Just as a point of curiosity, in some places, people are using for loops to avoid invalid pointer dereferences in the event that one of the queue items is removed by the code in the loop while iterating. Are you using TAILQ_FOREACH_SAFE() in such places if required? -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer FreeBSD Security Team
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44A45D3E.2040004>