Date: Mon, 18 Oct 2004 20:31:18 +0200 From: Erik Trulsson <ertr1013@student.uu.se> To: David O'Brien <obrien@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S Message-ID: <20041018183118.GA80703@falcon.midgard.homeip.net> In-Reply-To: <20041018174511.GA6079@dragon.nuxi.com> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua> <20041018174511.GA6079@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 18, 2004 at 10:45:11AM -0700, David O'Brien wrote: > On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > > obrien 2004-10-18 17:19:36 UTC > > > FreeBSD src repository > > > Modified files: > > > lib/libc/i386/net htonl.S ntohl.S > > > Log: > > > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. > > > Revision Changes Path > > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > > : ENTRY(__htonl) > > : movl 4(%esp),%eax > > : +#ifdef I386_CPU > > : xchgb %al,%ah > > : roll $16,%eax > > : xchgb %al,%ah > > : +#else > > : + bswap %eax > > : +#endif > > : ret > > > > Ahem, but this makes this code unsuitable for i386. > > Yes. You missed the discussion in freebsd-current on this? For > 6-CURRENT and RELENG_5 running on a real I386 is not supported. I have certainly not seen any message stating that on -current. I know that the GENERIC kernel does not work on a i386, so that you need a custom-built kernel to install on a real i386. I also know that support for FPU-less systems has been dropped, which means that most 386-based systems (those without an '387) (as well as systems with a 486sx w/o a 487sx) will not run RELENG_5 or -CURRENT. Neither of these means that a real 80386+80387 is unsupported, just that you need to build a new kernel first. I think you people need to decide to either drop support for 80386 completely (in which case all the '#ifdef I386_CPU' and similar can go away) or decide to keep support for it, in which case most things should just work 'out of the box' on a 80386 (without recompilation needed more than absolutely necessary.) -- <Insert your favourite quote here.> Erik Trulsson ertr1013@student.uu.se
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041018183118.GA80703>