Date: Thu, 25 Nov 2021 08:58:05 +0000 From: =?utf-8?B?Q29ydmluIEvDtmhuZQ==?= <C.Koehne@beckhoff.com> To: John Baldwin <jhb@FreeBSD.org>, Emmanuel Vadot <manu@FreeBSD.org>, "src-committers@FreeBSD.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@FreeBSD.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@FreeBSD.org" <dev-commits-src-main@FreeBSD.org> Subject: RE: git: 2eb2079554f4 - main - bhyve: keep physical and virtual COMMAND reg in sync Message-ID: <4b164dfd2112482cba7625a0cb04ac1e@beckhoff.com> In-Reply-To: <78d7b522-3de3-4011-c0cc-98e23779d577@FreeBSD.org> References: <202111221530.1AMFUUJn079855@gitrepo.freebsd.org> <428e410d-33c1-7ff8-9689-41943db3d9c3@FreeBSD.org> <084d5b5845554221901ce4902fb878d1@beckhoff.com> <0d0a6a77-b2d1-d0c2-f0de-e5c97307e140@FreeBSD.org> <80ac3d256ce94f809a39f5badc864588@beckhoff.com> <78d7b522-3de3-4011-c0cc-98e23779d577@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
Hi John, > While it's true that real systems do that on reset, most firmware set those bits > while populating BARs. Bhyve doesn't always run boot firmware to do those tasks > and needs to provide working devices out of the box. This is similar to how > bhyve pre-populates BARs with resources rather than relying on firmware to > assign resources to BARs. > > -- > John Baldwin Sry, I forgot it. I'm always running bhyve with OVMF. So I won't see such issues. Enabling bus mastering shouldn't hurt. Whether bhyve runs boot firmware or not. Should be a good idea to always enable it on start up. I'm unsure if it could cause trouble when enabling INTx by default. I'm missing some insights how bhyve's INTx support works. If you say that we should enable it by default, I'll trust you. What's your plan? Do you want to update your patch or do you want to wait until someone is facing some issues due to disabled bus mastering on startup? If you like, I can update your patch too. Best regards Corvin Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4b164dfd2112482cba7625a0cb04ac1e>