Date: Mon, 31 Jul 2006 09:44:45 GMT From: Paolo Pisati <piso@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 102841 for review Message-ID: <200607310944.k6V9ijPj002091@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=102841 Change 102841 by piso@piso_newluxor on 2006/07/31 09:43:49 Cosmetic Affected files ... .. //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_db.c#3 edit .. //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_dummy.c#6 edit Differences ... ==== //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_db.c#3 (text+ko) ==== @@ -1041,7 +1041,7 @@ switch (link_type) { struct tcp_dat *aux_tcp; - case LINK_ICMP: + case LINK_ICMP: la->icmpLinkCount++; break; case LINK_UDP: @@ -2537,7 +2537,7 @@ #ifndef NO_FW_PUNCH UninitPunchFW(la); #endif - LIST_REMOVE(la, instancelist); + LIST_REMOVE(la, instancelist); free(la); } ==== //depot/projects/soc2005/libalias/sys/netinet/libalias/alias_dummy.c#6 (text+ko) ==== @@ -29,10 +29,9 @@ /* * Alias_dummy is just an empty skeleton used to demostrate how to write * a module for libalias, that will run unalterated in userland or in - * kernel land + * kernel land. */ -/* Includes */ #ifdef _KERNEL #include <sys/param.h> #include <sys/ctype.h> @@ -72,25 +71,25 @@ fingerprint(struct libalias *la, struct ip *pip, struct alias_data *ah) { /* - * check here all the data that will be used later, if any field - * is empy/NULL, return a -1 value + * Check here all the data that will be used later, if any field + * is empy/NULL, return a -1 value. */ if (ah->dport == NULL || ah->sport == NULL || ah->lnk == NULL || ah->maxpktsize == 0) return (-1); /* - * fingerprint the incoming packet, if it matches any conditions - * return an OK value + * Fingerprint the incoming packet, if it matches any conditions + * return an OK value. */ if (ntohs(*ah->dport) == 123 || ntohs(*ah->sport) == 456) - return (0); /* i know how to handle it... */ - return (-1); /* i don't know this packet... */ + return (0); /* I know how to handle it. */ + return (-1); /* I don't recognize this packet. */ } /* * Wrap in this general purpose function, the real function used to alias the - * packets + * packets. */ static int @@ -154,6 +153,6 @@ static void AliasHandleDummy(struct libalias *la, struct ip *ip, struct alias_data *ah) { - ; /* dummy */ + ; /* Dummy. */ }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607310944.k6V9ijPj002091>