Date: Thu, 27 Apr 2000 11:57:49 -0400 From: James Housley <jim@thehousleys.net> Cc: freebsd-smp@FreeBSD.ORG Subject: Re: hlt instructions and temperature issues Message-ID: <3908637D.FA57D436@thehousleys.net> References: <200004271533.e3RFXoI01828@lor.watermarkgroup.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Luoqi Chen wrote:
>
> Index: swtch.s
> ===================================================================
> RCS file: /home/ncvs/src/sys/i386/i386/swtch.s,v
> retrieving revision 1.91
> diff -u -r1.91 swtch.s
> --- swtch.s 2000/03/29 06:15:38 1.91
> +++ swtch.s 2000/04/27 15:31:11
> @@ -258,9 +258,14 @@
>
> ENTRY(default_halt)
> sti
> -#ifndef SMP
> - hlt /* XXX: until a wakeup IPI */
> +#ifdef SMP
> +#ifdef CHEAP_TPR
> + movl $0, lapic_tpr
> +#else
> + andl $~APIC_TPR_PRIO, lapic_tpr
> +#endif /** CHEAP_TPR */
> #endif
> + hlt
> ret
>
I applied this patch to my 3.4-STABLE SMP cvs's yesterday afternoon.
According to healthd my temps were 44.5 and 38.5 for the CPUs. After
rebooting they cooled down to 32.0 and 30.0.
I guess the next question is, "Is this seriously impacting
performance?" Personaly a small hit is okay.
Jim
--
Do not meddle in the affairs of dragons, for you are crunchy and taste
good with ketchup.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3908637D.FA57D436>