Date: Sun, 3 Jun 2007 05:42:05 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/pccbb pccbb.c Message-ID: <200706030542.l535g54h022629@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
imp 2007-06-03 05:42:05 UTC
FreeBSD src repository
Modified files:
sys/dev/pccbb pccbb.c
Log:
Minor filter tweaks:
o If we don't have a filter, also check to make sure the card is there before
calling the scheduled ISR. This is necessary to help old drivers whose
ISRs can't cope with being called with the hardware missing, which sadly
still exist in the tree. This is the main reason why we have an extra
layer of indirection for cardbus interrupts.
o If the card is no longer present, mark the interrupt as 'handled' rather
than 'stray' because this accounts for why the interrupt happened. Stray
isn't all bad, since there are other filters that would claim it...
o Fix some comments
+ Add comment about why we check for CARD_OK and touch the hardware in both
the filter and ISR.
+ add a note about why we don't care about Giant
+ also note that giant can't be taken out in a filter...
+ Some minor formatting nits on very long comments.
Revision Changes Path
1.162 +47 -26 src/sys/dev/pccbb/pccbb.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706030542.l535g54h022629>