Date: Thu, 5 Feb 2015 17:06:55 -0800 From: NGie Cooper <yaneurabeya@gmail.com> To: Julian Elischer <julian@freebsd.org> Cc: "freebsd-arch@freebsd.org" <arch@freebsd.org> Subject: Re: Better way to do conditional inclusion in make Message-ID: <CAGHfRMAdOTUQZvU5D_1KYEyZdoaD4RJ2BTTOgUjrm3sK31U0kw@mail.gmail.com> In-Reply-To: <54D40DC4.9070907@freebsd.org> References: <39C20BA1-E6B1-4DAE-95BB-8011A0A64D54@bsdimp.com> <54D40DC4.9070907@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 5, 2015 at 4:41 PM, Julian Elischer <julian@freebsd.org> wrote: ... > how does it cope with the case where a single file is dependent on either of > two options. > (we have this in our tree.. not sure if it occurs in the FreeBSD tree.) > file could occur in both lists or twice in one list.. This is a good, valid point. I think that Warner's proposal will fix the simple case (using one knob), but not the more complex case. What concerns me about the short description of the implementation, (and something that I'm going to add to the phabricator review) is that this will: 1. Break using FILESGROUPS 2. Requires creating snippets for dealing with magic in bsd.*.mk (I wouldn't want this magic going into the general purpose snippets because it would probably break backwards compatibility). Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMAdOTUQZvU5D_1KYEyZdoaD4RJ2BTTOgUjrm3sK31U0kw>