Date: Thu, 10 Jul 2003 20:18:44 +0200 (CEST) From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at> To: Michael Haro <mharo@FreeBSD.org> Cc: ports@freebsd.org Subject: A small portlint update Message-ID: <Pine.BSF.4.56.0307102016090.19911@naos.dbai.tuwien.ac.at>
next in thread | raw e-mail | index | archive | help
This adds `file` and `strip` to the list of commands whose direct use
portlint warns about.
Michael, is this okay to commit? (I'm also Cc:ing this to ports@, in
case others want to chime in and voice comments.)
Gerald
Index: src/portlint.pl
===================================================================
RCS file: /sw/FreeBSD/CVSUP/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.35
diff -u -3 -p -r1.35 portlint.pl
--- src/portlint.pl 7 Mar 2003 17:00:43 -0000 1.35
+++ src/portlint.pl 9 Jul 2003 23:01:08 -0000
@@ -779,7 +779,7 @@ sub checkmakefile {
my %cmdnames = ();
print "OK: checking direct use of command names.\n" if ($verbose);
foreach my $i (qw(
-awk basename cat chmod chown cp echo expr false gmake grep gzcat
+awk basename cat chmod chown cp echo expr false file gmake grep gzcat
ldconfig ln md5 mkdir mv patch rm rmdir sed sh touch tr which xmkmf
)) {
$cmdnames{$i} = "\$\{\U$i\E\}";
@@ -788,6 +788,7 @@ ldconfig ln md5 mkdir mv patch rm rmdir
$cmdnames{'gunzip'} = '${GUNZIP_CMD}';
$cmdnames{'gzip'} = '${GZIP_CMD}';
$cmdnames{'install'} = '${INSTALL_foobaa}';
+ $cmdnames{'strip'} = '${STRIP_CMD}';
#
# ignore parameter string to echo command.
# note that we leave the command as is, since we need to check the
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.56.0307102016090.19911>