Date: Wed, 25 Jul 2018 16:32:35 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: [Bug 214338] [PATCH] devel/glib20: new kqueue() backend for file monitoring Message-ID: <bug-214338-6497-P5ylUzfuKQ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-214338-6497@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=214338 lightside <lightside@gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gnome@FreeBSD.org, | |lightside@gmx.com Attachment #195450| |maintainer-approval?(gnome@ Flags| |FreeBSD.org) --- Comment #45 from lightside <lightside@gmx.com> --- Created attachment 195450 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=195450&action=edit Proposed patch (since 473551 revision) Hello. I tested build for patch in attachment #191448 after ports r473551 changes and found following linker error on FreeBSD 10.4 amd64: -8<-- ./.libs/libgio-2.0.so: undefined reference to `mstosbt' cc: error: linker command failed with exit code 1 (use -v to see invocation) -->8- Therefore, I added implementation for mstosbt function to files/kqueue_fnm.c file, based on: https://svnweb.freebsd.org/base?view=revision&revision=321686 https://svnweb.freebsd.org/base/head/sys/sys/time.h?view=markup&pathrev=321686#l198 https://svnweb.freebsd.org/base/head/sys/sys/param.h?revision=321688&view=markup#l61 The `make check-plist` command found some errors (excerpt): -8<-- ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: lib/charset.alias Error: Orphaned: share/doc/gio/GAction.html <..> Error: Orphaned: share/doc/gobject/up.png ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Stop. <..> -->8- This is because of autoreconf usage on pre-configure-FAM_ALTBACKEND-on stage, which overwrites previous changes for Makefile.in files (see bug #226920, comment #4 for another explanation). I fixed this with using some sed changes for ${WRKSRC}/gio/kqueue/Makefile.in file. The files/extra-patch-gio_kqueue_Makefile.am patch was removed. Attached modified patch. Probably, there is a need to clarify description for FAM_ALTBACKEND option. For example, usage of "Alternative" instead of "Alternate" word. -- You are receiving this mail because: You are on the CC list for the bug.help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-214338-6497-P5ylUzfuKQ>