Date: Thu, 21 Feb 2002 12:12:48 -0700 From: "Long, Scott" <Scott_Long@btc.adaptec.com> To: "'Justin T. Gibbs'" <gibbs@scsiguy.com>, Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> Cc: freebsd-scsi@freebsd.org, joerg_wunsch@uriah.heep.sax.de Subject: RE: READ_6 patch (Re: RBC support patch) Message-ID: <CEDF5AA24668244F8D529010E2955A940A75EF@btcexc01.btc.adaptec.com>
next in thread | raw e-mail | index | archive | help
Also, after the 6 byte command has failed and been retried successfully as a 10 byte command, should the driver be flagged that all future commands use the 10 byte form? Scott > -----Original Message----- > From: Justin T. Gibbs [mailto:gibbs@scsiguy.com] > Sent: Thursday, February 21, 2002 11:02 AM > To: Hidetoshi Shimokawa > Cc: freebsd-scsi@freebsd.org; joerg_wunsch@uriah.heep.sax.de > Subject: Re: READ_6 patch (Re: RBC support patch) > > > >> This seems right way to go. > > > >How about this? > >Could you review this patch? > > Close. Perform the test inside daerror(). Daerror is > supposed to filter > out any errors specific to the da driver prior to calling the generic > error routine, so this is the place to handle this. You > should also only > need to do the filtering if the ccb has an error flagged in its ccb > header. This should avoid any unecessary work on transactions that > haven't failed. Lastly, you need to actually requeue the transaction > (xpt_action() followed by a release of the device queue if > the transaction > was marked as having frozen the queue). > > Thanks for looking into this! > > -- > Justin > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-scsi" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CEDF5AA24668244F8D529010E2955A940A75EF>