Date: Tue, 14 Oct 2014 18:10:46 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 194312] games/minecraft-server issues after update to 1.8 Message-ID: <bug-194312-13-eTdT1pe2BY@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-194312-13@https.bugs.freebsd.org/bugzilla/> References: <bug-194312-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D194312 --- Comment #7 from Helge Oldach <freebsd@oldach.net> --- (In reply to John Marino from comment #6) > I don't understand this: >=20 > .for file in ${CONFIG_FILES} > ${TOUCH} ${STAGEDIR}${ETCDIR}/${file}.sample > ${LN} -s ${ETCDIR}/${file} ${STAGEDIR}${DATADIR}/${file} > .endfor >=20 > What is this doing? >=20 > 1) it looks like blank sample files are being created Exactly. For some reasons the maintainer decided to install blank configura= tion files instead of meaningful content with the 1.8 port revision. At least, f= or server.properties it would really be sensible to install some pre-configured content. This was the case for the previous port revision. No idea why it w= as changed. Yes, these blank config files are ugly, however I felt it would be more sensible to make use of existing pkg logic rather than bloating Makefile wi= th in-line scripts. > 2) It looks like the next line was intended to be > ${LN} -s ${ETCDIR}/${file} ${STAGEDIR}${DATADIR}/${file}.sample Definitely not: The location of the configuration files is %%ETCDIR%%, i.e. /usr/local/etc/minecraft-server. In *this* location both the .sample file a= nd the user-modified "real" configuration file are located. However, the minec= raft executable expects its config files in %%DATADIR%%, i.e. /usr/local/share/minecraft-server, which is why symlinks are created there pointing to real file location (without .sample suffix). This is intentiona= l. > and even if it was, that's wrong. @sample keyword would take care of it. No, it doesn't. Tried and tested here (very recent 9-STABLE with pkg 1.3.8). > Can you fix the other issues? All we want is a patch (and not have to > create one ourselves) If I would want to be the port maintainer, I would volunteer. It did not. I= am just a bug reporter. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194312-13-eTdT1pe2BY>