Date: Tue, 26 Nov 2002 14:17:45 -0500 (EST) From: Garrett Wollman <wollman@lcs.mit.edu> To: FreeBSD-gnats-submit@FreeBSD.org Subject: conf/45766: rcNG broke non-system sshd startup Message-ID: <200211261917.gAQJHjBf017291@khavrinen.lcs.mit.edu>
next in thread | raw e-mail | index | archive | help
>Number: 45766
>Category: conf
>Synopsis: rcNG broke non-system sshd startup
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 26 11:20:01 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: Garrett Wollman
>Release: FreeBSD 5.0-CURRENT i386
>Organization:
MIT Laboratory for Computer Science
>Environment:
System: FreeBSD khavrinen.lcs.mit.edu 5.0-CURRENT FreeBSD 5.0-CURRENT #609: Mon Nov 25 16:08:14 EST 2002 root@:/usr/src/sys/i386/compile/KHAVRINEN i386
$NetBSD: sshd,v 1.18 2002/04/29 08:23:34 lukem Exp $
$FreeBSD: src/etc/rc.d/sshd,v 1.2 2002/06/13 22:14:36 gordon Exp $
>Description:
/etc/rc.d/sshd checks for the presence of a configuration file
which is only used by the system sshd. Systems which use another
sshd and have the system sshd disabled in the build will not have
this configuration file. This breaks a previously working
configuration.
>How-To-Repeat:
Update to a recent -current, run mergemaster, and reboot.
Try to log in remotely and note that sshd is not running.
>Fix:
I made this change to fix it (which also disables some other brokenness in
this script). My feeling in general is that startup scripts should not try
to outsmart the program they are starting; if the configuration file doesn't
exist, then it is right and proper for the program to fail with its own
error message rather than being second-guessed by the startup script.
Index: sshd
===================================================================
RCS file: /home/cvs/src/etc/rc.d/sshd,v
retrieving revision 1.2
diff -u -r1.2 sshd
--- sshd 13 Jun 2002 22:14:36 -0000 1.2
+++ sshd 26 Nov 2002 19:08:06 -0000
@@ -12,12 +12,11 @@
name="sshd"
rcvar=`set_rcvar`
-command="/usr/sbin/${name}"
keygen_cmd="sshd_keygen"
-start_precmd="sshd_precmd"
+#start_precmd="sshd_precmd"
pidfile="/var/run/${name}.pid"
-required_files="/etc/ssh/sshd_config"
-extra_commands="keygen reload"
+#required_files="/etc/ssh/sshd_config"
+#extra_commands="keygen reload"
sshd_keygen()
{
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200211261917.gAQJHjBf017291>