Date: Thu, 6 Sep 2018 11:25:33 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Alexander Motin <mav@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r338494 - head/sys/cam/ctl Message-ID: <20180906152533.ygsqei2jgod42ydt@mutt-hbsd> In-Reply-To: <51c27534-8cc2-cd30-dd53-77fd7ad5bdf7@FreeBSD.org> References: <201809061403.w86E3AUm097915@repo.freebsd.org> <20180906145421.7mejwhcfezwtsk4k@mutt-hbsd> <51c27534-8cc2-cd30-dd53-77fd7ad5bdf7@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--snqdvlofjpj57woe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 06, 2018 at 08:24:32AM -0700, John Baldwin wrote: > On 9/6/18 7:54 AM, Shawn Webb wrote: > > On Thu, Sep 06, 2018 at 02:03:10PM +0000, Alexander Motin wrote: > >> Author: mav > >> Date: Thu Sep 6 14:03:10 2018 > >> New Revision: 338494 > >> URL: https://svnweb.freebsd.org/changeset/base/338494 > >> > >> Log: > >> Add missing copyin() to access LUN and port ioctl arguments. > >> =20 > >> Somehow this was working even after PTI in, at least on amd64, and g= ot > >> broken by something only very recently. > >=20 > > Is anyone investigating why the direct access still worked? >=20 > PTI doesn't disable kernel access to user pages, it only disables > translation of kernel virtual addresses while in user mode. The thing th= at > catches this type of access is SMAP (which was only recently enabled on > x86). Whoops. Blonde moment. I blame the lack of caffeine in my body when I wrote the email. Too many acronyms to keep track of when tired. ;) Thanks for the clarification. --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --snqdvlofjpj57woe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAluRRugACgkQaoRlj1JF bu7ULA/+I1hk2FVR+dUlyVvrzC27vUO24PZAX/Fh4Iih/whj+PEAkJoPPwBviPGR QVt8Ie+NThM0Su3mcR8RxXopzoB3Bac8g+qo2AeIilfeVDUjOBFuqaSwVYeLbk9t 3Kg0+dxZSSnJ7B/odkMv6WiodDdK8lVpKtgQrrkrXrRLHlbpVJHSdPttrcJbD41G rf7uW9L45k6QK3Q3+Rqk9efD3ifeGSsAPvTe7I3HTROoDc9Oyi9lKQm28C+yfxTN elQG/lu1RUksbIUhZ7x7sNYFnzUhY3VOScZ4tno6rui7RY411DvpB+PXATe2WgRP VdO6dvH6FEqymxF3QX32HrgSZjJdEU1tTyL8D8PpWdliPVcILZg77fxhV/mHLTRz rHBf6vk78MW1znanJDLAPHyN1xrxB9HX/TwnQOLWLIJGHhKkxYZqL8/VP5ZoVpsb kqjLwzBxPo5ibYAGDYlwdebVo4y5P6czmaZBHFqOKKRglrQWiUH8JEkEzaVWldIx AEfoGZzxHyXeur4yqTiwwmVvIxujbwM7vJdpzuBmtkHfoULymy1r+Uxdlvksf4Mw X7kRrfH4C9yBXe8AASfLWRC8HtkTmlfKekNt/vnXjoiGJ/GaMhEetlMyl0UFQSpv PT3vAqvPMlt2RxnuWOutYGslPUssI9fVm/3OLdMo37aHe5wR7FE= =Jfjr -----END PGP SIGNATURE----- --snqdvlofjpj57woe--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180906152533.ygsqei2jgod42ydt>