Date: Mon, 29 Oct 2018 17:25:09 +0900 From: =?UTF-8?B?6rmA7KKF7ISx?= <jongsung.kim@gmail.com> To: =?UTF-8?Q?Bernhard_Fr=C3=B6hlich?= <decke@freebsd.org> Cc: ports@freebsd.org Subject: Re: multimedia/tvheadend cannot service live TV after upgrading v4.2.7 Message-ID: <CAOVNo=Amrze-Deoap4np5muOUzMM7C5EqeDxmLcMpZ5=a7LxHg@mail.gmail.com> In-Reply-To: <CAE-m3X3e2i3=XskeO0k=ojV4Bo2-MPaULLjmyYjV1U1fYcFBUA@mail.gmail.com> References: <CAOVNo=CrG57EpHSpKN6AZUerwfJen%2BObxuU9oB69F%2BOeVop42Q@mail.gmail.com> <CAE-m3X3e2i3=XskeO0k=ojV4Bo2-MPaULLjmyYjV1U1fYcFBUA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
We need to re-apply my second patch related to sendfile syscall too. The
current tvheadend can't service recorded media properly.
And I have another suggestion about web UI. I have seen abnormal behavior
in the EPG tab. The entire program list disapears when I click "Reset All"
button. This happens also when I type any search text and delete all. Linux
tvheadend users don't suffer this problem.
However, I found a way to fix this problem by modifying
src/webui/static/app/epg.js:
diff --git a/src/webui/static/app/epg.js b/src/webui/static/app/epg.js
index 650ac9202..d00b76557 100644
--- a/src/webui/static/app/epg.js
+++ b/src/webui/static/app/epg.js
@@ -1167,12 +1167,10 @@ tvheadend.epg =3D function() {
var value =3D c.getValue();
if (value.length < 1)
- value =3D null;
-
- if (epgStore.baseParams.title !=3D=3D value) {
+ delete epgStore.baseParams.title;
+ else if (epgStore.baseParams.title !=3D=3D value)
epgStore.baseParams.title =3D value;
- epgView.reset();
- }
+ epgView.reset();
});
epgFilterFulltext.on('check', function(c, value) {
But I don't know whether it's correct way and why it works, because I
totally don't know about web programming. Can anybody review this patch?
2018=EB=85=84 10=EC=9B=94 25=EC=9D=BC (=EB=AA=A9) =EC=98=A4=ED=9B=84 8:49, =
Bernhard Fr=C3=B6hlich <decke@freebsd.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=
=84=B1:
> On Tue, Oct 23, 2018 at 5:53 AM =EA=B9=80=EC=A2=85=EC=84=B1 <jongsung.kim=
@gmail.com> wrote:
> >
> > Hi decke,
> > tvheadend v4.2.7 has a merged commit 3895c923a FreeBSD: Fix recv proble=
m
> if no data received, which touches my previous merged commit 0d5c8efee tc=
p:
> fix tcp_socket_dead() for FreeBSD. It makes the FreeBSD port of tvheadend
> unable to service live TV, and reverted from the mainline. (f08bbef11
> Revert "FreeBSD: Fix recv problem if no data received.") Please apply thi=
s
> reverting patch:
> >
> > commit f08bbef11c77a6a81d4e2bf974e36e54b0cd14d6
> > Author: Jaroslav Kysela <perex@perex.cz>
> > Date: Tue Oct 16 16:51:00 2018 +0200
> >
> > Revert "FreeBSD: Fix recv problem if no data received."
> >
> > This reverts commit 3895c923a3a959da05080831b8146c09ed143b00.
> >
> > diff --git a/src/tcp.c b/src/tcp.c
> > index d15b4381f..5349784a4 100644
> > --- a/src/tcp.c
> > +++ b/src/tcp.c
> > @@ -454,11 +454,8 @@ tcp_socket_dead(int fd)
> > if (err)
> > return -err;
> > #ifdef PLATFORM_FREEBSD
> > - err =3D recv(fd, NULL, 0, MSG_PEEK | MSG_DONTWAIT);
> > - if (err < 0)
> > + if (recv(fd, NULL, 0, MSG_PEEK | MSG_DONTWAIT) < 0)
> > return -errno;
> > - else if (err =3D=3D 0)
> > - return -EIO;
> > #else
> > if (recv(fd, NULL, 0, MSG_PEEK | MSG_DONTWAIT) =3D=3D 0)
> > return -EIO;
> >
> > Thank you
> > JS
>
> Thanks! Committed in r482966.
>
> https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D482966
>
> --
> Bernhard Froehlich
> http://www.bluelife.at/
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOVNo=Amrze-Deoap4np5muOUzMM7C5EqeDxmLcMpZ5=a7LxHg>