Date: Wed, 20 Jul 2022 21:23:18 +0200 From: Gary Jennejohn <garyj@gmx.de> To: Warner Losh <imp@bsdimp.com> Cc: Toomas Soome <tsoome@me.com>, Dmitry Chagin <dchagin@heemeyer.club>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 84bf2bbbecc3 - main - stand: constrain zlib/gzip CFLAGS better Message-ID: <20220720212318.2b27beaa@ernst.home> In-Reply-To: <CANCZdfo%2BzQuyr3M0uuBGXEE%2BMp4hiChyzqSAF8icxQwdpeWQyw@mail.gmail.com> References: <202207081750.268Ho5kZ066824@gitrepo.freebsd.org> <Ytg6Noc7T8R6sLNy@heemeyer.club> <244CD526-C7D0-4D42-9DAB-6EA690DFD3A7@me.com> <CANCZdfpdKV0%2BaAKUbdVmmCaOjvKPccE1LwUGc8VDjzYVeV-sew@mail.gmail.com> <CANCZdfo%2BzQuyr3M0uuBGXEE%2BMp4hiChyzqSAF8icxQwdpeWQyw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 20 Jul 2022 12:12:57 -0600
Warner Losh <imp@bsdimp.com> wrote:
> On Wed, Jul 20, 2022 at 12:06 PM Warner Losh <imp@bsdimp.com> wrote:
>
> >> >> +CFLAGS.${i}+=3D${ZLIB_CFLAGS}
> >> >> +SRCS+=3D ${i}
> >> >> +.endfor
> >> >>
> >> >> # lz4 decompression functionality
> >> >> .PATH: ${SRCTOP}/sys/cddl/contrib/opensolaris/common/lz4
> >> >> @@ -168,9 +170,8 @@ SRCS+=3D time.c
> >> >> .PATH: ${SRCTOP}/sys/ufs/ffs
> >> >> SRCS+=3Dffs_subr.c ffs_tables.c
> >> >>
> >> >> -CFLAGS.dosfs.c+=3D -I${LDRSRC}
> >> >> -CFLAGS.tftp.c+=3D -I${LDRSRC}
> >> >> -CFLAGS.ufs.c+=3D -I${LDRSRC}
> >> > ^^^^^^^^^^^^ is this correct? at least it breaks builds with
> >> > WITHOUT_LOADER_ZFS and WITHOUT_BOOT probably, see PR/260083
> >> >
> >> >
> >>
> >> No, it is not correct.
> >>
> >
> > My change is correct, theoretically. However, there's a layering viola=
tion
> > that means they are needed so it was premature.
> >
> > I'll fix a bandaide and do it better when I return from vacation.
> >
>
> Doh! I don't have the right keys loaded in my ssh-agent, so I can't push
> the change because the port forwarding on my router is broken and I can'=
t
> remotely login :(
>
> If someone could commit the change I suggested in
> https://reviews.freebsd.org/D35860 that would be great!
>
Well, I can say that Warner's recommended change fixes building libsa
for me. Couldn't build libsa earlier today without makeing some hackey
changes to dosfs.c, tftp.c and ufs.c.
=2D-
Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220720212318.2b27beaa>