Date: Tue, 09 Jan 2001 21:44:30 -0700 From: Warner Losh <imp@harmony.village.org> To: Mike Smith <msmith@FreeBSD.org> Cc: Matt Jacob <mjacob@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/include bus.h Message-ID: <200101100444.f0A4iUs58704@harmony.village.org> In-Reply-To: Your message of "Tue, 09 Jan 2001 14:37:57 PST." <200101092237.f09MbvJ01112@mass.osd.bsdi.com> References: <200101092237.f09MbvJ01112@mass.osd.bsdi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200101092237.f09MbvJ01112@mass.osd.bsdi.com> Mike Smith writes: : > mjacob 2001/01/09 10:17:49 PST : > : > Modified files: : > sys/alpha/include bus.h : > Log: : > The alpha architecture is 64 bits, so bus_addr_t && bus_size_t should really : > be 64 bits wide. The largest known current actual physical implementation : > is 40 bits, so BUS_SPACE_MAXADDR should reflect this. It also seems to : > me that BUS_SPACE_UNRESTRICTED should b ~0UL, not ~0. : : Where a constant is of a known type, one should avoid "UL" in favour of : the real type, eg. (~(bus_addr_t)0). There's too much "long" in the bus : code already. 8( Yes. And shouldn't we have #defines for these things? Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101100444.f0A4iUs58704>