Date: Mon, 22 Jun 2009 15:14:42 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r194629 - head/sys/net Message-ID: <20090622151017.H22887@maildrop.int.zabbadoz.net> In-Reply-To: <200906221507.n5MF7CIq044459@svn.freebsd.org> References: <200906221507.n5MF7CIq044459@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 22 Jun 2009, Bjoern A. Zeeb wrote: > Author: bz > Date: Mon Jun 22 15:07:12 2009 > New Revision: 194629 > URL: http://svn.freebsd.org/changeset/base/194629 > > Log: > Collect all VIMAGE_GLOBALS variables in one place. > > No longer export rt_tables as all lookups go through > rt_tables_get_rnh(). > > We cannot make rt_tables (and rtstat, rttrash[1]) static as > netstat -r (-rs[1]) would stop working on a stripped > VIMAGE_GLOBALS kernel. > > Reviewed by: zec > Presumably broken by: phk 13.5y ago in r12820 [1] Which seriously leads to the questions: 1) is this because we do not ship stripped kernels? 2) is the kvm_* interface to read them the wrong way? 3) those stats are useless and should be garbage collected entirely? I only tripped over this because I wanted to do the same to rt_tables as phk did 13.5 years back to rtstat,rttrash and Marko made me tripple check things. -- Bjoern A. Zeeb The greatest risk is not taking one.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090622151017.H22887>