Date: Wed, 7 Apr 2021 18:07:30 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Vincenzo Maffione <vmaffione@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 15dc713ceb57 - main - netmap: vtnet: add support for netmap offsets Message-ID: <20210407220730.6z6j2ejytu3j67ik@mutt-hbsd> In-Reply-To: <CA%2B_eA9ip2YGwiJFtcC94mAMwnXBdB7uFU=9%2B2-myzBghkvvTgg@mail.gmail.com> References: <202104072142.137LgrJC015011@gitrepo.freebsd.org> <20210407214622.gsedn2cuuj7mblq2@mutt-hbsd> <CA%2B_eA9ip2YGwiJFtcC94mAMwnXBdB7uFU=9%2B2-myzBghkvvTgg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--esmlgnma4wdtnhxg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable No, just the one line: (void)addr; On Wed, Apr 07, 2021 at 11:58:45PM +0200, Vincenzo Maffione wrote: > Hi, > Do you mean the whole commit? This adds vtnet support for "offsets" in > the netmap buffers. Main use case is that applications can easily zerocopy > push and pop protocol headers from packets. >=20 > Cheers, > Vincenzo >=20 > On Wed, Apr 7, 2021, 11:46 PM Shawn Webb <shawn.webb@hardenedbsd.org> wro= te: >=20 > > Hey Vincenzo, > > > > On Wed, Apr 07, 2021 at 09:42:53PM +0000, Vincenzo Maffione wrote: > > > The branch main has been updated by vmaffione: > > > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=3D15dc713ceb57d0d61c1dc54b1d550= da42d250730 > > > > > > commit 15dc713ceb57d0d61c1dc54b1d550da42d250730 > > > Author: Vincenzo Maffione <vmaffione@FreeBSD.org> > > > AuthorDate: 2021-04-07 21:32:20 +0000 > > > Commit: Vincenzo Maffione <vmaffione@FreeBSD.org> > > > CommitDate: 2021-04-07 21:32:20 +0000 > > > > > > netmap: vtnet: add support for netmap offsets > > > > > > Follow-up change to a6d768d845c173823785c71bb18b40074e7a8998. > > > This change adds support for netmap offsets. > > > --- > > > sys/dev/netmap/if_vtnet_netmap.h | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > diff --git a/sys/dev/netmap/if_vtnet_netmap.h > > b/sys/dev/netmap/if_vtnet_netmap.h > > > index a05781255218..a423e71331be 100644 > > > --- a/sys/dev/netmap/if_vtnet_netmap.h > > > +++ b/sys/dev/netmap/if_vtnet_netmap.h > > > @@ -84,12 +84,14 @@ vtnet_netmap_txsync(struct netmap_kring *kring, i= nt > > flags) > > > for (; nm_i !=3D head; nm_i =3D nm_next(nm_i, lim)) { > > > /* we use an empty header here */ > > > struct netmap_slot *slot =3D &ring->slot[nm_i]; > > > + uint64_t offset =3D nm_get_offset(kring, slot); > > > u_int len =3D slot->len; > > > uint64_t paddr; > > > void *addr =3D PNMB(na, slot, &paddr); > > > int err; > > > > > > - NM_CHECK_ADDR_LEN(na, addr, len); > > > + (void)addr; > > > > What is this change for? > > > > Thanks, > > > > -- > > Shawn Webb > > Cofounder / Security Engineer > > HardenedBSD > > > > > > https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb= /03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc > > --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --esmlgnma4wdtnhxg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmBuLSIACgkQ/y5nonf4 4fo3Mg//bSObVg3MZ1sG6AziQOMrCrexwj0wLgni1DTsrlhJ5ZUNi72Kd8cnptaF h78O0Qi6ryDyV2rDWneFDBvdQrmkZlV3BfDCIeKFaRj1PqQkezYfAZgcaXOdZQuH 0r+wtiHQEf3mCqENfzcp8B4aKgb95JH1xBMZ23irpz1hFF8DpqvmOeqoXPfbU+ca ME/e9uHNwhO7q8+Px36/N3Dc4g3SEimSIwkDRLuNlw+T9sTcJ71l4OtgJz9PfNsm j99gnCi35R/hodDrFkWKN1h/biTzM6lahuVPK5cltFkUoyVGPWlOEAIncptrwLJ0 nPlWN3dZmDqQqnde15YWxYDO1tqT81x8GMAGHFebiAOx1VtYCCYzQ5vEZblaQ0vj Im+ObsuyGM7XwRuUjJtcLhzTCwlbwqPgZWQ766jlOv+2h7dv52sxqB60gmku6YwX vzhXdtytx+pweLg7SfbeRyYMCkYNNdnnXV/JBV6l3nSF8cZW9mb9+BeECoa/V4mA NOdszRTbiQgs2sfmI62gXc461Q0e0lU5nVYtufMNoHVbPOgzTo4XBnlsek8pxyaA 8V0ZE44wO8rGLgZh5QhkZg42RscpacAWRlpnUP9hjyjBq8a32zEYRJddFuMOi6DF lBg/JeDPB+xXZxUHINEO+mjTc0Sa3alpMjGhFuGlhTYBXHOgNpI= =YhmQ -----END PGP SIGNATURE----- --esmlgnma4wdtnhxg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210407220730.6z6j2ejytu3j67ik>