Date: Mon, 5 Feb 2018 22:25:55 +0100 From: "O. Hartmann" <ohartmann@walstatt.org> To: Jason Harmening <jason.harmening@gmail.com> Cc: "O. Hartmann" <ohartmann@walstatt.org>, David Wolfskill <david@catwhisker.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328489 - head/sys/conf Message-ID: <20180205222622.43f5d3e7@thor.intern.walstatt.dynvpn.de> In-Reply-To: <e6a89b40-8ce3-d688-d9ec-c918718a0509@gmail.com> References: <201801272013.w0RKDaMU098200@repo.freebsd.org> <20180127214755.3c59661e@thor.intern.walstatt.dynvpn.de> <98501f75-1a1b-9221-c52d-24415230a886@gmail.com> <20180129130022.GT1125@albert.catwhisker.org> <20180204133337.3d03f01d@thor.intern.walstatt.dynvpn.de> <e6a89b40-8ce3-d688-d9ec-c918718a0509@gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
Am Sun, 4 Feb 2018 10:22:31 -0800
Jason Harmening <jason.harmening@gmail.com> schrieb:
> On 02/04/18 04:33, O. Hartmann wrote:
> > Am Mon, 29 Jan 2018 05:00:22 -0800
> > David Wolfskill <david@catwhisker.org> schrieb:
> >
> >> On Mon, Jan 29, 2018 at 02:10:04AM -0800, Jason Harmening wrote:
> >>>>
> >>>> This happens now if PORTS_MODULE=x11/nvidia-driver is defined in /etc/src.conf:
> >>>>
> >>>> [...]
> >>>> --- kernel-install ---
> >>>> mkdir -p /boot/kernel
> >>>> install -p -m 555 -o root -g wheel kernel /boot/kernel/
> >>>> --- ports-install ---
> >>>> Variable OBJTOP is recursive.
> >>>>
> >>>> make[8]: stopped
> >>> ...
> >>>
> >>> David sent me logs of the failing case; thanks David!
> >>
> >> Happy to help! :-)
> >>
> >>> The failure happens when buildkernel and installkernel are run
> >>> separately instead of all-up, e.g. 'make kernel'. The installkernel
> >>> step is leaving MK_AUTO_OBJ=no in the env passed to the port build. It
> >>> looks like at least one of the install stages of nvidia-driver needs to
> >>> generate temporary output, which leads to confusion when the port isn't
> >>> built as though it's an in-tree component.
> >>>
> >>> Can you guys try out the attached patch?
> >>
> >> I tried it both on my build machine (which does not use kernel modules
> >> from ports, and thus did not exhibit the problem -- but I thought that
> >> verifying that the patch did not break that case worth checking) and on
> >> my laptop (which did exhibit the problem).
> >>
> >> It worked in both cases with no issues for me.
> >>
> >> Thanks! :-)
> >>
> >> Peace,
> >> david
> >
> > The problem still persists!
> >
> > I'm on CURRENT, FreeBSD 12.0-CURRENT #32: Sun Feb 4 09:41:39 CET 2018 amd64, the
> > source tree is at revision 328839.
> >
> >
> > I use WITH_META_MODE=YES in /etc/src.conf. My /etc/make.conf consists of a .include
> > statement which reels in /usr/local/etc/ports.conf in which I define everything
> > outside the source tree for ports (in case of the nvidia driver, its DISTVERSION).
> > This worked before and should work again. Today I checked out a completely
> > fresh /usr/src and gleanced the /usr/obj folder and rebuilt the system - and get the
> > error again:
> >
> > [...]
> > ===> Ports module x11/nvidia-driver (install)
> > cd ${PORTSDIR:-/usr/ports}/x11/nvidia-driver; env -u CC -u CXX -u CPP -u
> > MAKESYSPATH MAKEFLAGS="-j 4 -J 15,16 .MAKE.LEVEL.ENV=MAKELEVEL KERNEL=kernel
> > MK_AUTO_OBJ=no
> ^^^^^
> Looks like you haven't applied the patch? MK_AUTO_OBJ being left set in
> MAKEFLAGS by installkernel was part of the problem.
>
> That said, the fix I have up for review is slightly different:
> https://reviews.freebsd.org/D14143
>
> > TARGET=amd64 TARGET_ARCH=amd64" SYSDIR=/usr/src/sys
> > PATH=/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/bin:/usr/obj/usr/src/amd64.amd64/tmp/legacy/bin:/usr/obj/usr/src/amd64.amd64/tmp/usr/sbin:/usr/obj/usr/src/amd64.amd64/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin:/usr/local/sbin
> > SRC_BASE=/usr/src OSVERSION=1200056
> > WRKDIRPREFIX=/usr/obj/usr/src/amd64.amd64/sys/THOR make -B deinstall reinstall ===>
> > Deinstalling for nvidia-driver ===> Deinstalling nvidia-driver-387.34 Updating
> > database digests format: . done Checking integrity... done (0 conflicting)
> > Deinstallation has been requested for the following 1 packages (of 0 packages in the
> > universe):
> >
> > Installed packages to be REMOVED:
> > nvidia-driver-387.34
> >
> > Number of packages to be removed: 1
> >
> > The operation will free 99 MiB.
> > [1/1] Deinstalling nvidia-driver-387.34...
> > [1/1] Deleting files for nvidia-driver-387.34: .......... done
> > ===> Staging for nvidia-driver-387.34
> > ===> nvidia-driver-387.34 depends on file: /usr/local/lib/libGL.so - found
> > ===> nvidia-driver-387.34 depends on file: /usr/local/libdata/pkgconfig/x11.pc -
> > found ===> nvidia-driver-387.34 depends on
> > file: /usr/local/libdata/pkgconfig/xorg-server.pc
> > - found ===> nvidia-driver-387.34 depends on
> > file: /usr/local/libdata/pkgconfig/xext.pc
> > - found ===> Generating temporary packing list
> > ===> src (install)
> > ===> src/nvidia (install)
> > Variable OBJTOP is recursive.
> >
> > make[8]: stopped
> > in /usr/obj/usr/src/amd64.amd64/sys/DUMMBOX/usr/ports/x11/nvidia-driver/work/NVIDIA-FreeBSD-x86_64-387.34/src/nvidia
> > *** Error code 2
> >
> >
> >
> > Oliver
> >
make -jX installkernel with the above mentioned setting of PORTS_MODULE= set
in /usr/src.conf doesn't wor even on recent CURRENT r328901.
make kernel doesn't fail.
oh
--
O. Hartmann
Ich widerspreche der Nutzung oder Übermittlung meiner Daten für
Werbezwecke oder für die Markt- oder Meinungsforschung (§ 28 Abs. 4 BDSG).
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iLUEARMKAB0WIQQZVZMzAtwC2T/86TrS528fyFhYlAUCWnjL/gAKCRDS528fyFhY
lD7RAf9Xd2j2xaDwQ3uzijGFe/YgSD2tW21DJDDUZgvGNE1WMaCyd/ctys4ZSAu7
UBQYAzdXB88tu5FXsYNV9i51eYx9AgCNfJgxbZ9/sVzkrWuqmnkeUF3kwo/IY6gj
C/QHiTXsKPNIC2uHK9n6RLEgumnOjsc6MnJjMl7HIpnh+PaS+vbh
=MNNn
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180205222622.43f5d3e7>