Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 May 2025 19:37:17 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 15143ba61a3b - main - sdt: Fix a typo in arm's sdt_tracepoint_valid()
Message-ID:  <202505131937.54DJbHWK045989@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=15143ba61a3b154023095afa333b25592af4b904

commit 15143ba61a3b154023095afa333b25592af4b904
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2025-05-13 19:36:24 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2025-05-13 19:36:24 +0000

    sdt: Fix a typo in arm's sdt_tracepoint_valid()
    
    Reported by:    Mark Millard <marklmi@yahoo.com>
    Fixes:          ddf0ed09bd8f ("sdt: Implement SDT probes using hot-patching")
---
 sys/arm/arm/sdt_machdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/arm/arm/sdt_machdep.c b/sys/arm/arm/sdt_machdep.c
index 02361497ee8d..12119ae6db37 100644
--- a/sys/arm/arm/sdt_machdep.c
+++ b/sys/arm/arm/sdt_machdep.c
@@ -24,7 +24,7 @@ sdt_tracepoint_valid(uintptr_t patchpoint, uintptr_t target)
 	    patchpoint + 2 * INSN_SIZE < patchpoint)
 		return (false);
 	offset = target - (patchpoint + 2 * INSN_SIZE);
-	if (offset < -(1 << 24) || offset > (1 >> 24))
+	if (offset < -(1 << 24) || offset > (1 << 24))
 		return (false);
 	return (true);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202505131937.54DJbHWK045989>