Date: Fri, 3 Jul 1998 02:39:45 +0200 From: Eivind Eklund <eivind@yes.no> To: Kevin Day <toasty@home.dragondata.com> Cc: andreas@klemm.gtn.com, current@FreeBSD.ORG Subject: Re: -current wishlist Message-ID: <19980703023945.08867@follo.net> In-Reply-To: <199807030035.TAA04624@home.dragondata.com>; from Kevin Day on Thu, Jul 02, 1998 at 07:35:30PM -0500 References: <19980702213011.35162@follo.net> <199807030035.TAA04624@home.dragondata.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 02, 1998 at 07:35:30PM -0500, Kevin Day wrote:
> > These fix a couple of reasons for such problems, I think. They're
> > completely untested. Feel free to test them :-)
> >
>
> I'll give them a try. :)
>
> However...
>
> >
> > Index: ccd.c
> > ===================================================================
> > RCS file: /home/ncvs/src/sys/dev/ccd/ccd.c,v
> > retrieving revision 1.32
> > diff -u -r1.32 ccd.c
> > --- ccd.c 1998/03/09 20:39:26 1.32
> > +++ ccd.c 1998/05/31 01:10:56
> > @@ -427,7 +433,7 @@
> > printf("ccd%d: interleave must be at least %d\n",
> > ccd->ccd_unit, (maxsecsize / DEV_BSIZE));
> > #endif
> > - while (ci >= cs->sc_cinfo) {
> > + while (ci && ci >= cs->sc_cinfo) {
> > free(ci->ci_path, M_DEVBUF);
> > ci--;
> > }
>
> I'm not quite sure I understand how this would help. If this were happening,
> shouldn't ccd blow up all over the place? :) Or is it just a case of 'lets
> make really sure'? :)
This one only strikes in an obscure error condition WRT a previous
malloc, IIRC.
> > @@ -918,7 +929,8 @@
> > #endif
> > cb[0] = cbp;
> > if (cs->sc_cflags & CCDF_MIRROR &&
> > - (cbp->cb_buf.b_flags & B_READ) == 0) {
> > + (cbp->cb_buf.b_flags & B_READ) == 0
> > + && ci2) {
> > /* mirror, start one more write */
> > cbp = getccdbuf();
> > bzero(cbp, sizeof (struct ccdbuf));
>
> I'm not mirroring, so I doubt this is the cause.. (if that helps you narrow
> things down)
Not really - I'm not running CCD, as I said. I just do patches based
on 'obvious errors'.
> In any case, thanks a lot, I'll apply and see what happens. :)
You're welcome.
Eivind.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980703023945.08867>