Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 8 Sep 2023 18:08:20 +0300
From:      Matthias Fechner <mfechner@freebsd.org>
To:        Guido Falsi <madpilot@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: f11ed4160472 - main - devel/libgit2: update to 1.6.4
Message-ID:  <d2b5c219-6288-fbb5-3d7b-924ca2305ca5@freebsd.org>
In-Reply-To: <6e61cd7f-fa81-a6e9-f601-996a3a21162b@FreeBSD.org>
References:  <202309081035.388AZWKP075486@gitrepo.freebsd.org> <6e61cd7f-fa81-a6e9-f601-996a3a21162b@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Am 08.09.2023 um 17:06 schrieb Guido Falsi:
> /wrkdirs/usr/ports/devel/libgit2/work/libgit2-1.6.4/src/util/util.c:731:28: 
> error: incompatible function pointer types passing 'int (void *, const 
> void *, const void *)' to parameter of type 'int (*)(const void *, 
> const void *, void *)' [-Wincompatible-function-pointer-types]
>         qsort_s(els, nel, elsize, git__qsort_r_glue_cmp, &glue);
>                                   ^~~~~~~~~~~~~~~~~~~~~
> /usr/include/stdlib.h:396:11: note: passing argument to parameter here
>     int (*)(const void *, const void *, void *), void *);
>           ^
> 1 error generated.
>
>
> The commit which added the patch to fix this is here:
>
> https://cgit.freebsd.org/ports/commit/devel/libgit2?id=a62f1b5796b641bb502b33f7f073238a49dc4d0c 
>
>
>
> Looking at upstream it looks like this fix is included there only 
> starting from version 1.7.0 (correct me if I'm wrong)
>
> I'll take a look at adding back the patch. 

sry, this was by accident.
I just cherry-picked the commit and will make a test-round if all is 
fine and will push the commit after that.

Gruß
Matthias

-- 

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d2b5c219-6288-fbb5-3d7b-924ca2305ca5>